Build Failure: Please Update SPIRV-Tools (and other) Submodules about moltenvk HOT 6 CLOSED

also please update SPIR-V Cross also up to KhronosGroup/SPIRV-Cross@15a941c
this fixes a vkquake shader error with same name used in variable and function..

from moltenvk.

Bump

from moltenvk.

The "workaround" for this is to fix the SPIRV-Tools file utils/generate_grammar_tables.py. At SPIRV-Tools @ 1acce99, this file has a mixture of tabs and spaces, which Python 3 does not tolerate. This problem is fixed with a later revision of SPIRV-Tools, but this repo points at an earlier version.

To work around the problem with this revision, convert the tabs to spaces in this file.

from moltenvk.

Confirmed Karl. Thanks.

from moltenvk.

@karl-lunarg

PR #98 changes the way that external libraries are fetched and built, and should fix this issue.

The glslang version is now derived from V-LVL...and SPRIV-Tools and SPIRV-Headers are now fetched by glslang

In addition...when MoltenVk is being built as a component of V-LVL, the fetchDependencies script can be called with a -sdk argument that will cause it to symlink to the V-LVL and glslang directories within the parent V-LVL.

The Vulkan header files used by MoltenVK are now derived from those in V-LVL too.

Please verify with the latest version of MoltenVK.

@oscarbg

SPIRV-Cross has been updated in PR #98 too.

from moltenvk.

I'll verify on March 16th.

I may have some suggestions for an alternative to the -sdk argument. One wouldn't use this only for SDK construction. Rather, it would be used anytime someone was building V-LVL, whether it was for an SDK or not. In any case, I'll make a PR if I see the need.

from moltenvk.