Comments (22)
karl-lunarg
commented on August 23, 2024
2
@irobertmanley You shouldn't really use getLatestAll. getLatestAll is for the case where a MoltenVK developer wants to update submodules to their latest versions. Often, a change in a submodule may require some adjustment in the rest of MoltenVK to cope with the change. For regular building, you really need to leave the submodule revisions alone and use makeAll (which should sync the submodule trees to the correct version).
As for the missing generated include file, see issue #84. I'll update that issue with a workaround.
from moltenvk.
billhollings
commented on August 23, 2024
1
PR #98 changes the way that external libraries are fetched and built, and should fix this issue. Among other significant changes, the getLatestAll script has been removed.
As @karl-lunarg indicates...the getLatestAll script was unintentionally dangerous. It was only intended to be used by MoltenVK devs who are deliberately moving MoltenVK to use another version of an external library. It was not intended to be used as a mechanism for app devs to use different versions of the external libraries...as doing so causes issues like this.
from moltenvk.
nyotis
commented on August 23, 2024
your build details are crystal-clear, unfortunately it seems I am missing something...
from moltenvk.
nyotis
commented on August 23, 2024
the problem shows up for both MoltenVK Debug and Release targets.
/Users/nikyotis/Developer/MoltenVK/MoltenVKShaderConverter/MoltenVKSPIRVToMSLConverter/SPIRV-Tools/source/opt/instruction.cpp:513:10: Use of undeclared identifier 'spvInstructionBinaryToText'
Maybe I should just add the header? namespace prepending does not really help...
from moltenvk.
nyotis
commented on August 23, 2024
Modifying the signature of /var/instruction.h && /var/instruction.cpp so that PrettyPrint returns void does not help either...
from moltenvk.
nyotis
commented on August 23, 2024
from moltenvk.
karl-lunarg
commented on August 23, 2024
This builds fine for me. I have the same version of Xcode as you. Also, the Travis-CI build is OK.
I do note that my version of Instruction.cpp has only 451 lines in it. And you are getting an error at line 513.
Are you sure you are using the latest sources?
If you do a git pull on the MoltenVK repo, you may need to do git submodule update in order to freshen the submodule content. The External/makeAll script does this submodule update for you. You may want to run this script again to get all the submodules updated and rebuilt.
Some of the other error messages in your screenshots also suggest that this could be the problem.
from moltenvk.
nyotis
commented on August 23, 2024
Thanks @karl-lunarg. I am gonna try fresh once more.
from moltenvk.
irobertmanley
commented on August 23, 2024
Still have the problem here on clean clone + makeAll or after getLatestAll.
from moltenvk.
nyotis
commented on August 23, 2024
Problem persists here as well..
I will fork and have a look at the bug.
NG
…On Fri, Mar 9, 2018 at 2:52 PM, irobertmanley ***@***.***> wrote:
Still have the problem here on clean clone + makeAll or after getLatestAll.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAoNH6n2t46-_e7jRRONHm7T9dpQ3SOPks5tcokLgaJpZM4ShGeu>
.
--
Nikolaos Giotis
from moltenvk.
nyotis
commented on August 23, 2024
from moltenvk.
irobertmanley
commented on August 23, 2024
There are completely separate versions of instruction.cpp - one in val and one in opt. One version doesn't have it, the other does.
from moltenvk.
nyotis
commented on August 23, 2024
Thanks Robert
…On Fri, Mar 9, 2018 at 3:45 PM, irobertmanley ***@***.***> wrote:
There are completely separate versions of instruction.cpp - one in var and
one in opt. One version doesn't have it, the other does.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAoNHwhF6iv8JpUDBkkXsHBjURJSEVePks5tcpV1gaJpZM4ShGeu>
.
--
Nikolaos Giotis
from moltenvk.
nyotis
commented on August 23, 2024
What I do not understand is how Travis Continues Integration did not flag
this at first place..
Maybe some Tests are missing?
…On Fri, Mar 9, 2018 at 3:46 PM, Nikolaos Giotis ***@***.***> wrote:
Thanks Robert
On Fri, Mar 9, 2018 at 3:45 PM, irobertmanley ***@***.***>
wrote:
> There are completely separate versions of instruction.cpp - one in var
> and one in opt. One version doesn't have it, the other does.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#87 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAoNHwhF6iv8JpUDBkkXsHBjURJSEVePks5tcpV1gaJpZM4ShGeu>
> .
>
--
Nikolaos Giotis
--
Nikolaos Giotis
from moltenvk.
irobertmanley
commented on August 23, 2024
Perhaps they are not using High Sierra and APFS? Still finding minor filesystem differences here that may affect the scripts.
from moltenvk.
nyotis
commented on August 23, 2024
Sure. At least we test the source for High Sierra..
…On Fri, Mar 9, 2018 at 3:50 PM, irobertmanley ***@***.***> wrote:
Perhaps they are not using High Sierra and APFS? Still finding minor
filesystem differences here that may affect the scripts.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAoNH_H8a9AC5Aj3yF9BTO8dcaxPUe5Nks5tcpbHgaJpZM4ShGeu>
.
--
Nikolaos Giotis
from moltenvk.
irobertmanley
commented on August 23, 2024
Worth noting that I only get this error after getLatestAll. There is a different error on clean makeAll regarding a missing generated include file.
from moltenvk.
nyotis
commented on August 23, 2024
thanks for the heads-up
from moltenvk.
irobertmanley
commented on August 23, 2024
makeAll based build now working with that update.
from moltenvk.
nyotis
commented on August 23, 2024
Thanks Karl!
Nikolaos Giotis
…On Mar 9, 2018 16:49, "Karl Schultz" ***@***.***> wrote:
@irobertmanley <https://github.com/irobertmanley> You shouldn't really
use getLatestAll. getLatestAll is for the case where a MoltenVK developer
wants to update submodules to their latest versions. Often, a change in a
submodule may require some adjustment in the rest of MoltenVK to cope with
the change. For regular building, you really need to leave the submodule
revisions alone and use makeAll (which should sync the submodule trees to
the correct version).
As for the missing generated include file, see issue #84
<#84>. I'll update that
issue with a workaround.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAoNH9FPPYY1yQxRTc8kIFcKW9Q9s0lEks5tcqSbgaJpZM4ShGeu>
.
from moltenvk.
karl-lunarg
commented on August 23, 2024
@nyotis If you are building fine now, it would help @billhollings if you could close this issue. I think that #84 sufficiently tracks the other problem.
from moltenvk.
nyotis
commented on August 23, 2024
both Debug and Release build now fine
from moltenvk.
Related Issues (20)
- Graphical glitch in DCS: World - MoltenVK 1.2.5 - DXVK (crossover) HOT 4
- Emulate sampler lod bias
- Incorrect ICD Path Resolution when loaded from After FX Plugin HOT 2
- Vulkan SDK release feature cut-off Friday March 1 HOT 1
- Texture creation crashing in b56c152a1245 HOT 11
- Issues with native atomics
- regression bug with vkGetBufferDeviceAddress HOT 1
- Request: Add previous field to MVKPerformanceTracker struct HOT 4
- SPIR-V to MSL conversion error in MoltenVK but not when using spirv-cross command line HOT 15
- Need to correctly handle vertex attribute alignment (vec3, potentially more) HOT 1
- Invalid driver dylib generated since #2170 HOT 9
- Support Privacy Manifest files HOT 2
- Missing dylib symlink breaks cmake's FindVulkan.cmake for MoltenVK optional component HOT 9
- ver 1.3.280.0 failed for 'VK_ERROR_INCOMPATIBLE_DRIVER' on macOS 14.3.1 HOT 3
- [1.3.280] Confusing Validation error stating I'm trying to use 1.3 features but my API version is 1.3.0 HOT 5
- OpAtomicSMax behaves as unsigned HOT 1
- Add support for VK_EXT_host_image_copy extension
- Improved Zink support
- Low maxVariableDescriptorCount being reported HOT 1
- 1.2.8 release build failure HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moltenvk.