Typescript support about react-modern-calendar-datepicker HOT 17 CLOSED

@Kiarash-Z module bundlers won't load type definition files and consequently type definitions will not appear in the JS bundle files. In fact, the package size will grow but the bundle size will not.
Type definitions only will be load by TypeScript compiler from types property in package.json file.

from react-modern-calendar-datepicker.

I added new branch for this feature and after merge, your package need a new version(like 1.1.0) and need to publish on npm

@thebrodmann
@Kiarash-Z

from react-modern-calendar-datepicker.

@Kiarash-Z @thebrodmann
There is another way and its i add this index.d.ts file as a package to DefinitelyTyped so developers can install types (like @types/react-modern-calendar-datepicker).
Im glad to do that too.

from react-modern-calendar-datepicker.

@Kiarash-Z can you share statistics? It should not affect the JS part of the package!

There is another way and its i add this index.d.ts file as a package to DefinitelyTyped so developers can install types (like @types/react-modern-calendar-datepicker).

I don't recommend this solution. Usually, It's a plan B when maintainers of a module don't wanna accept the maintenance of the type definition.

from react-modern-calendar-datepicker.

Hi @arminyahya,

Does this index.t.ts file need to be published on NPM? or it just gets fetched automatically by the repo connected to the package?

from react-modern-calendar-datepicker.

@Kiarash-Z it should publish. I can work on this.

from react-modern-calendar-datepicker.

@thebrodmann @arminyahya Wouldn't this result in extra bundle size?

from react-modern-calendar-datepicker.

@Kiarash-Z
No, this is only for developer experience and doesn't effect the main bundle

from react-modern-calendar-datepicker.

@arminyahya just tried it, and it adds up to bundle size 😶

from react-modern-calendar-datepicker.

Gotta do some research to find an efficient way to add this 🤔

from react-modern-calendar-datepicker.

@thebrodmann I just considered it simple. When it's gonna get published, it will be there on node_modules/react-modern-calendar-datepicker, and that means it would add up to bundle size, wouldn't it? If it's not going to be there then how developers would detect the types?

from react-modern-calendar-datepicker.

@thebrodmann Got it! thanks for the clear explanation. You can work on a PR for this if you wish. By the way, is adding types by an index.d.ts file the best way for adding types?

from react-modern-calendar-datepicker.

@Kiarash-Z @thebrodmann
I did a PR for this before.
Didn't you Receive that?

from react-modern-calendar-datepicker.

@arminyahya Nope. Nothing in Pull Requests section:/

from react-modern-calendar-datepicker.

@Kiarash-Z @thebrodmann
Hmm
I finished this last week,maybe i forget something.
Let me back home and create a PR.

from react-modern-calendar-datepicker.

By the way, is adding types by an index.d.ts file the best way for adding types?

Yeah, I think so. It's our plan A. :D

from react-modern-calendar-datepicker.

Resolved in #64

from react-modern-calendar-datepicker.