If <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id=

I think the biggest "offender" is my macro <div class="highlight highlight-source-

This works great! thanks <a class="user-mention notranslate" data-hovercard-type="user

Please have a look if the path I took in <a href="https://crates.io/crates/tzdb/0.6.0-

Make `iana-time-zone` dep and `local_tz` function optional about tzdb HOT 4 CLOSED

kijewski commented on September 26, 2024

Make `iana-time-zone` dep and `local_tz` function optional

from tzdb.

Comments (4)

Kijewski commented on September 26, 2024 1

I think the biggest "offender" is my macro

macro_rules! unwrap {
    ($($tt:tt)*) => {
        match $($tt)* {
            Ok(value) => value,
            Err(_) => {
                #[allow(unconditional_panic)]
                let err = [][0];
                err
            }
        }
    }
}

If I replace it with ↓, then the compile time is about 4 times faster in the simple test I did.

pub(crate) const fn time_zone_ref_new(
    transitions: &'static [tz::timezone::Transition],
    local_time_types: &'static [tz::LocalTimeType],
    leap_seconds: &'static [tz::timezone::LeapSecond],
    extra_rule: &'static Option<tz::timezone::TransitionRule>,
) -> TimeZoneRef<'static> {
    match TimeZoneRef::new(transitions, local_time_types, leap_seconds, extra_rule) {
        Ok(value) => value,
        Err(_) => {
            #[allow(unconditional_panic)]
            let err = [][0];
            err
        },
    }
}

I'll test it properly in the next few days.

Changing the default features would be a breaking change. But I could use breaking change this to increase the msrv from 1.56 to 1.57, so I could use panic!() in time_zone_ref_new(). I'll think about it. :)

from tzdb.