Validate inputs in constructor about a-range HOT 7 CLOSED

Yup, I'm putting a bound for PartialOrd for Idx.

from a-range.

Looks like a good time to learn Rust. Can I work on this?

from a-range.

Absolutely! Let me know if you have any questions!

from a-range.

Hi! would you like me to throw explicit panics or do you have something else in mind?

from a-range.

@babhishek21 good question. I'd go with a panic for now, as it's most likely a programmer error; in teh future, we can introduce try_up_to and similar if people ask for it.

from a-range.

@killercup So, I was going to put in panics of the sort:

panic!("Cannot count upwards from {} to {}", self.from, x);   // `self.from` and `x` are both of generic type `Idx`

But that'd mean putting bounds for Idx to be std::fmt::Displayable (which really shouldn't be hard requirement for consumers of this crate). So how do I keep my panics descriptive enough?

from a-range.

Well, you could use debug output ({:?}) but that'd require Debug, of course. It's implemented by more types, but still a needless constraint.

I'd probably just go with a generic message like "invalid range: upper bound cannot be less than lower bound" (or reverse for… reverse).

Speaking of bounds: Seems like this also means we'll need PartialOrd to check of <=/>=. It's a bit stricter than PartialEq, but does make sense over all.

from a-range.