Giter VIP home page Giter VIP logo

Comments (4)

nbigaouette avatar nbigaouette commented on June 26, 2024

Could the levels be enums and not integers? There was also discussion about using RUST_LOG in #46. How would that fit in?

from quicli.

CAD97 avatar CAD97 commented on June 26, 2024

I think LoggerBuilder::from_env should be called at the start, such that an environment variable can be used for overrides. I mean, that's the reason to use env_logger, isn't it? But that seems orthogonal.

If we're designing an easy wrapper around "the logging implementation", we shouldn't be afraid to use log's terminology to talk about it. Therefore I think the following signature feels best currently (subject to bikeshed of course):

fn set_up_logger(
    default: ::log::LevelFilter,
    overrides: &[(&str, ::log::LevelFilter)],
) -> Result<()>

from quicli.

killercup avatar killercup commented on June 26, 2024

I think LoggerBuilder::from_env should be called at the start

👍

If we're designing an easy wrapper around "the logging implementation"

FTR, originally, the function was about turning "number of -v flags given" into a LogLevel.

I'm still unsure of what kind of API to expose (cf. #51 (comment))

from quicli.

vitiral avatar vitiral commented on June 26, 2024

from quicli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.