Comments (4)
Could the levels be enums and not integers? There was also discussion about using RUST_LOG
in #46. How would that fit in?
from quicli.
I think LoggerBuilder::from_env
should be called at the start, such that an environment variable can be used for overrides. I mean, that's the reason to use env_logger
, isn't it? But that seems orthogonal.
If we're designing an easy wrapper around "the logging implementation", we shouldn't be afraid to use log
's terminology to talk about it. Therefore I think the following signature feels best currently (subject to bikeshed of course):
fn set_up_logger(
default: ::log::LevelFilter,
overrides: &[(&str, ::log::LevelFilter)],
) -> Result<()>
from quicli.
I think LoggerBuilder::from_env should be called at the start
👍
If we're designing an easy wrapper around "the logging implementation"
FTR, originally, the function was about turning "number of -v
flags given" into a LogLevel
.
I'm still unsure of what kind of API to expose (cf. #51 (comment))
from quicli.
from quicli.
Related Issues (20)
- issue in 'getting started' HOT 2
- Issue with glob in thumbnail tutorial HOT 2
- Include `read_input`?
- bail!() no longer works with quicli 0.4 HOT 1
- Quicli in the wild HOT 2
- Testing, examples, docs, CI
- Move Result type out of the prelude HOT 2
- Update failure to 1.0.0 on March 15
- docs and crates to support re-parsing the command line (readline style)
- export clap macros HOT 2
- Unix pipes support out of the box HOT 1
- Switch to globwalk
- human-panic
- Readme example doesn't compile HOT 2
- StructOpt not found in scope HOT 3
- "methods are not allowed for flattened entry" HOT 1
- Expose remove_dir_all crate HOT 1
- main! macro emits warning
- Turn on logging in all subcrates? HOT 2
- use of deprecated item 'failure::Error::causes' HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quicli.