Failed to import plugin plugins.ginger.Ginger about ginger HOT 7 CLOSED

Nice catch. Only happened because you've ran Ginger without Kimchi I believe.

We'll need to either move this to WoK or import it to Ginger. I guess the first option is better because it avoids duplicating code. Any comments, @alinefm ?

from ginger.

Moving to ginger-base is another option as well

from ginger.

Hi @danielhb! Hi @chandrureddy!

Wok should only contain what is needed to start up the web server. So it is not an option for this.
I suggest move the common code to ginger-base and adjust the imports in Kimchi and Ginger.

from ginger.

Thanks for the input @alinefm !

For anyone willing to solve this issue: be careful with adjusting Kimchi imports. They'll not appear only as 'wok.plugins.kimchi.disks' but also as 'import disks' in all the source files inside /plugins/kimchi/model/ dir.

I can work in this after fixing #37 .

from ginger.

Hi @danielhb

I will be taking care of this in my next patch.

from ginger.

Thanks @pkulkark

from ginger.

This bug was referring specifically to errors in the the 'disks' module. These errors were fixed upstream a while ago.

from ginger.