Giter VIP home page Giter VIP logo

Comments (2)

KinWaiCheuk avatar KinWaiCheuk commented on May 14, 2024

Hi tasercake, thanks for pointing out this problem and providing a possible fix.
The reason for having the self.output_format in STFT.forward() is that Griffin-Lim (another inverse function inside STFT) requires the complex output.
But you are right, we should figure out a way to avoid this bug while allowing Griffin-Lim to work.

Since this fix will also affect Griffin-Lim, I think I need more time later to investigate.
Alternatively, would you like to make a pull request? So that I can just check your fix to see if it works for Griffin-Lim too.

I will post the instruction on how to do unit test if you are interested in doing a pull request.

from nnaudio.

tasercake avatar tasercake commented on May 14, 2024

I've created a PR with the changes I made on my end (though I haven't changed/added any tests yet) - #53

At least in my specific use case of inverting a magnitude spectrogram via Griffin-Lim, these changes didn't seem to cause any issues

from nnaudio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.