Not-so-brief Comments about investopedia-trading-api HOT 4 CLOSED

Thanks for the feedback! I've made pretty much all of the fixes you've recommended. The only thing I've left is making getPortfolioStatus more elegant - I'll probably need to use a library like BeautifulSoup to do that, so I I need to read up on it first. Let me know what you think of the changes.

from investopedia-trading-api.

Very nicely done. Note that the namedtuple constructor is only meant to be created once- for example,

Status = namedtuple('Status', '...')

class Account:
    def getPortfolioStatus(self):
        ...
        return Status(...)

You can also use keyword arguments when creating your Status object, for example

Status(
    cash_value=something,
    ...
)

Just to make your code clearer; but it's optional.

from investopedia-trading-api.

I am on mobile so I'm sorry that I couldn't squash this into a single comment- is there a good reason to return True and False in the Account.trade method? Normally we'll just let exceptions be raised.

from investopedia-trading-api.

Initially, I thought it would be useful to suppress any exceptions during trading (so that an error wouldn't bring the whole trading algorithm to a halt). Looking at it now, it's probably more sensible to let users do whatever they want with exceptions (instead of this class already suppressing it for them).

from investopedia-trading-api.