Giter VIP home page Giter VIP logo

Comments (5)

d3ward avatar d3ward commented on September 28, 2024 2

@KaKi87
I investigated a little bit and found out that the original project besticons handle the subdomains too while logos.kiwibrowser doesn't, so seems like to be a server side bug i think
Comparing the example

Server google.com translate.google.com
Besticons Link Link
Logos.Kiwibrowser Link Link

@kiwibrowser you might take a look at that server

from src.next.

KaKi87 avatar KaKi87 commented on September 28, 2024

Potentially related to #158 (comment)

from src.next.

d3ward avatar d3ward commented on September 28, 2024

This , logically it's not a bug , the favicon is auto fetched by a server, it take the favicon from the website and in this case the website ( translate.google.com ) it's a subdomain of google.com so , it takes the favicon from last one .

Since that issue it's old and the default homepage will not undergo changes and implementation of new features, over time was born an alternative more customizable NextNTP which includes among other things the adding of custom logo on tiles

from src.next.

KaKi87 avatar KaKi87 commented on September 28, 2024

@d3ward This issue should then be transferred to https://github.com/d3ward/nextntp since this project uses the same favicon provider as the current NTP.

I see this as a bug because it does not seem logical to use the root domain's favicon when looking up a subdomain's favicon.

Google's favicon provider, for example, returns the subdomain's favicon : https://www.google.com/s2/favicons?domain=translate.google.com

from src.next.

d3ward avatar d3ward commented on September 28, 2024

With the new logos workflow , this issue is fixed

from src.next.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.