Add Storyshots about orbit HOT 13 CLOSED

It's not fine to have files in PR no one reads and updates blindly when it's broken. It just bring illusion of being tested

from orbit.

Please only if it does not produce one huge snapshot file. No one reads that during code review

from orbit.

@michalsanger Huge snapshot file is fine if it shows only relevant changes. The issue with the implementation on Balkan was that classnames were generated for the entire project instead of each component. So when you updated classnames you would update all of the classnames, rendering it unreadable.

from orbit.

So you’re saying that snapshot tests have no purpose?

from orbit.

Our aim should be to have functioning documentation via Storybook. How do you want to guarantee that all components still render?

from orbit.

I'm saying having huge snapshot file is a problem, because if developer accidentally updates it no one will review those changes, because the file will be big and messy. It's the same with PR with 10 changed files vs 100 changed files. Or how many times do you review content of yarn.lock?

Having snapshots per component looks better to me.

from orbit.

But Github shows you only the changes between master and the branch. What does it matter if it's big if it shows only the relevant changes?

I can check if Storyshots allows per story files yet.

from orbit.

Are the changes readable? Will you understand that the snapshot change is OK or it's broken? This should come with easy visual verification. Generate storybook for every PR or maybe even faster generate gallery of screenshots

https://www.npmjs.com/package/storybook-chrome-screenshot

from orbit.

Does GitHub allow you to view visual changes between images?

The changes are DOM output changes. They should be readable.

from orbit.

I don't need visual testing 🚀 science. I need quick way to see component works. I can spent few seconds running through images when I see something was changed in storyshots. But it would suck if I would have to checkout the branch, install deps, run storybook, find the story...

from orbit.

Does GitHub allow you to view visual changes between images?

Yes, it shows the old and new image (see the commit):

from orbit.

Thanks. We will use the visual storyshot testing.

from orbit.

Closed in favour of #75

from orbit.