No cassettes found on vcrpy==5.0.0 release. Works with 4.* about pytest-recording HOT 10 CLOSED

Hi!

Thanks for opening an issue! A WIP PR is here

from pytest-recording.

@Alexander-Serov thanks for the report!

Expected behavior

• correctly interact with vcrpy==5.0

• intercept the new exception

I think you meant raising CassetteDecodeError or CassetteNotFoundErrorinstead.

• suggestion: in future, limit compatibility to a major upstream version only vcrpy~=5.0 and perform major updates manually.

I would like to vote for just vcrpy>=5.0 (or no limit) and leave the rest to the and user / consuming application. Bumping VCR.py from 4.x.x to 5.0.0 is a major version bump in semver so the user has full responsibility in my view.

from pytest-recording.

Thank you @hartwork !

I'll release a new version this week! :) Hopefully, I could also take a look at the tests that are failing on VCRPy 5.0

from pytest-recording.

@hartwork agreed on bumping to a major version, and pytest-recording is the user in this case. But to avoid accidents like this one, when the pipeline becomes blocked, I would vote for setting vcrpy>=5.0,<6 in this repo, with the update to 6 done manually. This would give time to the maintainers of this repo to implement changes and test without people like me coming and opening issues. And the end user does not specify a version of vcrpy since it's an internal dep of pytest-recording for us. Just my 2 cents.

@Stranger6667 Thanks for already working on it!

from pytest-recording.

The new version is released! 🎉 Thank you for your patience

from pytest-recording.

I guess the props for working on the issue should go to @gadomski :)

At this point, instead of failing in runtime, it would be better to note that pytest-recording is compatible only with vcrpy<4.4.0 (there is 1 failing test)

from pytest-recording.

Hi folks, I see the PR #110 has been suspended for now. Is there any plan or intention in this direction?

from pytest-recording.

hi @mezhaka !

Yes, I'd like to add support for vcrpy==5.0.0, but I don't have the bandwidth at the moment. Meantime, PRs (including those adding partial support) are welcome

from pytest-recording.

@Stranger6667 thanks for partial, I'll give it another shot right now…

from pytest-recording.

Pull request #118 now ready for a first round of review.

from pytest-recording.