Misleading error message: Codepoint U+0027 at position 2 of "b'foo bar'" not allowed about idna HOT 5 CLOSED

It looks like it's because the except UnicodeError on line 269 of core.py is intended to be catching only exceptions from line 261 label = label.encode('ascii') but is also catching the perfectly good error message idna.core.InvalidCodepoint: Codepoint U+0020 at position 4 of 'foo bar' not allowed that is being thrown by ulabel because InvalidCodepoint is an indirect subclass of UnicodeError.

This bug is therefore already fixed by ebefacd which made IDNAError not be a subclass of UnicodeError anymore.

from idna.

Thanks for taking a look @jribbens !

from idna.

Okay, so I tried the latest version.

$ python3 foo.py
Traceback (most recent call last):
  File "/home/joern/idna/lib/python3.5/site-packages/idna-2.2-py3.5.egg/idna/core.py", line 263, in alabel
  File "/home/joern/idna/lib/python3.5/site-packages/idna-2.2-py3.5.egg/idna/core.py", line 299, in ulabel
  File "/home/joern/idna/lib/python3.5/site-packages/idna-2.2-py3.5.egg/idna/core.py", line 253, in check_label
idna.core.InvalidCodepoint: Codepoint U+0020 at position 4 of 'foo bar' not allowed

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "foo.py", line 2, in <module>
    idna.encode(b'foo bar')
  File "/home/joern/idna/lib/python3.5/site-packages/idna-2.2-py3.5.egg/idna/core.py", line 355, in encode
  File "/home/joern/idna/lib/python3.5/site-packages/idna-2.2-py3.5.egg/idna/core.py", line 265, in alabel
idna.core.IDNAError: The label b'foo bar' is not a valid A-label

The "good" exception is now visible. But what's with the second? :)

from idna.

It's the appalling way Python 3 reports exceptions. ulabel throws the first exception listed above, which is caught by line 264 in alabel and the second exception is thrown. Both of them appear correct and I don't think this behaviour is a problem.

from idna.

In that case, everything appears to be in order now. Thank you!

from idna.