Giter VIP home page Giter VIP logo

Comments (4)

enitrat avatar enitrat commented on September 17, 2024 1

is not used eniwhere

lol

from kakarot-ssj.

enitrat avatar enitrat commented on September 17, 2024 1

I think you're going to have a hard time for now, it's best to do it later. Especially if we change test runner, we will need to write unit tests in the same modules, make a lot of modifications to the structure, etc

from kakarot-ssj.

TAdev0 avatar TAdev0 commented on September 17, 2024

@enitrat there is a an issue with the corelib that makes it impossible for now to update to 2023_11 :
the nullable_from_box function currently has a pub(crate) visibility, hence its not possible to use it in any other crate.

https://github.com/starkware-libs/cairo/blob/ad6aeb70ac0ab6c6c129eb088df682705d4f1853/corelib/src/nullable.cairo#L14

Everything else in nullable.cairo is pub , and nullable_from_box is not used eniwhere in the corelib so the pub(crate) attribute doesn't make sense.

Currently, for example in vec.cairo file in alexandria data structre:

    fn push(ref self: NullableVec<T>, value: T) -> () {
        self.items.insert(self.len.into(), core::nullable::nullable_from_box(BoxTrait::new(value)));
        self.len = core::integer::u32_wrapping_add(self.len, 1_usize);
    }
    ```
Item `core::nullable_from_box` is not visible in this context.

from kakarot-ssj.

TAdev0 avatar TAdev0 commented on September 17, 2024

@enitrat i'm working on it , i can be assigned to it

from kakarot-ssj.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.