Make install does not work with USE_PGXS=1 about pgfincore HOT 4 CLOSED

Hi,

Great tools !

thank you!

Make install does not find "pgfincore--unpackaged--1.0.sql".
There is also some warning at "make time".

[...]

root# make USE_PGXS=1 clean
rm -f pgfincore.so pgfincore.o
rm -f sql/pgfincore--1.0.sql

root# make USE_PGXS=1
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wformat-security -fno-strict-aliasing -fwrapv -fpic -I. -I. -I/usr/local/pgsql91/include/server -I/usr/local/pgsql91/include/internal -D_GNU_SOURCE   -c -o pgfincore.o pgfincore.c
pgfincore.c: In function ‘pgfadvise_file’:
pgfincore.c:224:4: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘long long int’ [-Wformat]
pgfincore.c: In function ‘pgfincore_file’:
pgfincore.c:740:9: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘long long int’ [-Wformat]
pgfincore.c:769:11: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘int64’ [-Wformat]
pgfincore.c:769:11: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘long long int’ [-Wformat]
pgfincore.c:788:7: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘long long int’ [-Wformat]
pgfincore.c:788:7: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 5 has type ‘long long int’ [-Wformat]
pgfincore.c:788:7: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 has type ‘long long int’ [-Wformat]
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wformat-security -fno-strict-aliasing -fwrapv -fpic -L/usr/local/pgsql91/lib -Wl,--as-needed -Wl,-rpath,'/usr/local/pgsql91/lib',--enable-new-dtags  -shared -o pgfincore.so pgfincore.o
rm pgfincore.o

root# make USE_PGXS=1 install
/bin/mkdir -p '/usr/local/pgsql91/share/extension'
/bin/mkdir -p '/usr/local/pgsql91/lib'
/bin/mkdir -p '/usr/local/pgsql91/share/doc/extension'
/bin/sh /usr/local/pgsql91/lib/pgxs/src/makefiles/../../config/install-sh -c -m 644 ./pgfincore.control '/usr/local/pgsql91/share/extension/'
/bin/sh /usr/local/pgsql91/lib/pgxs/src/makefiles/../../config/install-sh -c -m 644 ./pgfincore--unpackaged--1.0.sql ./pgfincore--1.0.sql  '/usr/local/pgsql91/share/extension/'
/usr/local/pgsql91/lib/pgxs/src/makefiles/../../config/install-sh: ./pgfincore--unpackaged--1.0.sql does not exist.
make: *** [install] Erreur 1

Ahhh!
DATA = pgfincore--unpackaged--$(EXTVERSION).sql
pgfincore--$(EXTVERSION).sql
should probably be
DATA = sql/pgfincore--unpackaged--$(EXTVERSION).sql
sql/pgfincore--$(EXTVERSION).sql

About the warning, it is not a real problem, my issue is that it
output warning on some platform, not other, I need to rewrite the
printf expression.

thanks for the report, I'll update that soon.

Cédric Villemain +33 (0)6 20 30 22 52
http://2ndQuadrant.fr/
PostgreSQL: Support 24x7 - Développement, Expertise et Formation

from pgfincore.

b6a3b8b

fix the Make issue.

from pgfincore.

Just tested and it's OK.
Great job and great speed !

from pgfincore.

7b034c7

should fix the compiler warning for the printf of (int64).

I have choose to cast to long long int, which might not be the best solution (PostgreSQL has something in its configure file about that, I'll look to improve later if required)

from pgfincore.