Klarna examples using deprecated code about kco_rest_dotnet HOT 7 CLOSED

New model Klarna.Rest.Core.Model.Checkout.Order is using CheckoutMerchantUrls which is Deprecated. But MerchantUrls is not used. Very confusing... Is there no conversion?

    [JsonProperty(PropertyName = "merchant_urls")]
    public CheckoutMerchantUrls MerchantUrls { get; set; }

from kco_rest_dotnet.

Trying to use the captureobject, why does Klarna.Rest.Core.Model.OrderManagement.Order OrderLines not using same orderline object as CaptureObject.OrderLines ? #confused

Does it exists any conversions?

    public async Task Capture(Klarna.Rest.Core.Model.OrderManagement.Order order)
    {
        await Klarna.OrderManagement.CreateCapture(order.OrderId, new CaptureObject()
        {
            CapturedAmount = order.OrderAmount,
            Description = "name of store",
            OrderLines = order.OrderLines
        });
    }

from kco_rest_dotnet.

Hi there @LucGosso and thank you for raising these issues. In our effort to maintain backwards compatibility with older models we've inadvertently caused some trouble.

There is an ongoing effort to fix this here #94.
We hope to get the examples updated in the same go. However due to limited availability, we cannot guarantee a delivery date.

A changelog relating to each release can be found here: https://github.com/klarna/kco_rest_dotnet/blob/v3.x/CHANGELOG.md

from kco_rest_dotnet.

thx, seems to me we should go to version 3.1.9 meanwhile. is that a good option @freethan ?

IMHO dont be afraid of bumping a version and introduce breaking changes. looks messy when new api extends old.

from kco_rest_dotnet.

Hi again @LucGosso . Yes indeed, I would propose to stay clear from 3.1.10 for now if this is causing troubles for you and wait for a bug fix release, or even better a breaking change version coming out later.

Thanks for the good feedback, we appreciate it 👍

from kco_rest_dotnet.

Closing this issue. The plan is to release a v3.1.12 as the final 3.x release without any attempts to maintain compatibility.

from kco_rest_dotnet.

Good decision, if it is breaking, it should be v4. https://semver.org/

from kco_rest_dotnet.