Giter VIP home page Giter VIP logo

Comments (5)

klausmeyer avatar klausmeyer commented on May 31, 2024 2

Got your point. It shouldn't be difficult to add HTTPS support as the used app server has built-in support for it. It's just about providing a way to enable it and configure the cert/key pair.

I'll see if I can find some time in the next days to give it a try.

from docker-registry-browser.

waldner avatar waldner commented on May 31, 2024 1

Thanks! It works fine.

from docker-registry-browser.

klausmeyer avatar klausmeyer commented on May 31, 2024

Hi @waldner,

it's best practice to not directly expose application-servers like the one I'm using in this project (puma) to clients. That's why the application itself does not support to configure TLS.

I would recommend using for example nginx as a reverse-proxy in front which does the TLS offloading and passes the requests to the application. You can simply run it as another docker container on the same host and link it to the docker-registry-browser container.

from docker-registry-browser.

waldner avatar waldner commented on May 31, 2024

While in general I agree with you, I was asking specifically about the docker image. It's not uncommon for many self-contained dockerized applications which run a web server or expose an HTTP API to offer an HTTPS option (either via docker environment variables or the application's own configuration file), to avoid having to spin extra containers just for that. Some examples that come to mind: elasticsearch, docker registry, gogs, rabbitmq, jenkins just to name a few I've used.
I think it's not difficult to implement and allow the user to enable it via some variables. If not, then of course I'll go with the reverse proxy setup (which is what I do already, after all).

from docker-registry-browser.

klausmeyer avatar klausmeyer commented on May 31, 2024

@waldner I managed to implement something now.

Please check the latest image and have a look at the updated README.

from docker-registry-browser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.