Giter VIP home page Giter VIP logo

Comments (2)

klbostee avatar klbostee commented on July 29, 2024

Nice enhancement, David. The additional function call might have a slight performance impact, but it should be minimal (if not negligible) and the benefits seem to be worth it.

I think we should be able to come up with a better name than "key_check" though. What it really does is determine if the secondary method should be blocked or not, so maybe something like "if not secondary_blocked(key.body):"? It's not that important I guess, but especially if the plan is to let people override it then it would make sense to use a clear name.

from dumbo.

dehowell avatar dehowell commented on July 29, 2024

I agree, key_check is not the best name, and secondary_blocked seems good. I'll update the names in my fork.

from dumbo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.