Giter VIP home page Giter VIP logo

Comments (5)

KleoPetroff avatar KleoPetroff commented on May 11, 2024

This is actually a pretty nice idea, @Piero87. I've played a bit with the loader and it seems to be working great with webpack 3.

Something I've been thinking is, should I keep the eslint rules as it is, using Airbnb's config, or rework them to return warnings instead of errors (similar to create-react-app). What do you thing?

Regardless of that, I would most certainly integrate eslint-loader to the project. I will first test it a bit more on a branch, react-webpack-boilerplate/eslint-loader, and I hope to add it to the project by the end of the week.

Once again, thanks for the great suggestion! 🎉

from react-webpack-boilerplate.

Piero87 avatar Piero87 commented on May 11, 2024

I appreciate you think is a good idea, I think that to write a good JavaScript You have to stick to the guides, otherwise you risk only with the warnings of not looking and writing maybe in a bad way. If you work in a team for example is really important that everyone write the same code As if everyone was the same person, giving continuity to the code. So the Eslint give you a block with error that you must to fix before go on. I take that suggestion reading this amazing blog:
https://www.robinwieruch.de/react-eslint-webpack-babel/#eslintBabel
https://www.robinwieruch.de/minimal-react-webpack-babel-setup/#babelSetup

from react-webpack-boilerplate.

KleoPetroff avatar KleoPetroff commented on May 11, 2024

From what I understand you favor eslint's errors more than the warnings, right?

from react-webpack-boilerplate.

Piero87 avatar Piero87 commented on May 11, 2024

Yes, I'm always in favor of writing a good javascript, so I in this way is better the error than the warning. I don't know if it's possible in webpack, but you could use a parameter to enable or disable it at the startup of the script, maybe with two start different start script.

from react-webpack-boilerplate.

KleoPetroff avatar KleoPetroff commented on May 11, 2024

With #148, the project now supports continuous linting.

from react-webpack-boilerplate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.