Knockback not RequireJS-compatible about knockback HOT 4 CLOSED

Arron, thank you for the patch and enhancing my understanding of module loading! It is a little tricky to implement in CoffeeScript given the way they compiler joins and wraps the JavaScript, but I'll get on it today.

Out of curiosity, your patch says "Support three module loading scenarios" but there is not a [1]. Is there another scenarios I should also support?

Cheers,

Kevin

from knockback.

Hi Kevin,

My apologies, I didn't even read the comments. The factory code is borrowed from knockout.js, but I deleted the first condition in that branch which was a check for module.exports (node.js compatibility). Since I didn't see the need for it, I took it out.

You can see the source from knockout here, if you're interested:
https://github.com/SteveSanderson/knockout/blob/master/build/output/knockout-latest.debug.js

I also changed the factory(window['ko'] = {}); (3rd condition) the knockout version to factory.call(window) to be compatible with the context of your original code.

In that example, the DEBUG statement can come out too :) sorry for being so sloppy, I was at work, and in a bit of a rush towards the end of my day :)

If you have any other questions, please let me know,

Cheers!
Aaron

from knockback.

Thanks for clarifying...much appreciated!

I've taken a look and it might take me a little time to fix because I need to update the build process to get the wrapping to work with the CoffeeScript compiler (might think I will need to add a post-build wrapping step).

from knockback.

Hi Aaron,

I'm sure your work around is working fine in the short term, but I just updated the knockback repository. It was a bit tricky given the build process, but seems to be working: 4ea1f4d

I have a couple more things to do until I release 0.16.2 officially.

Cheers,

Kevin

from knockback.