KnapsackPro::Hooks::Queue.before_queue not being called when running multiple nodes about knapsack_pro-ruby HOT 4 CLOSED

Hi @Pro777

KnapsackPro::Hooks::Queue.before_queue won't be called when CI node got from Queue API an empty list of tests to run. For instance, CI node started work too late after other CI nodes already did run all test files from Queue API.

I don't know if this is the case here. You mentioned "By skipping that hook an important portion of the test setup is missing causing that most of the tests fail on that thread." so it looks like some tests are still executed on the CI node.

Can you provide more details like:

• link to the CI build in user dashboard.
• what are CI node indexes for CI nodes that did not run KnapsackPro::Hooks::Queue.before_queue
• log output from nodes that did not run the hook
• Did you added hook in spec/spec_helper.rb or rails_helper.rb Maybe some of your spec files don't require proper file and then hook is not called?

Here you can see how hook is called:

If you want you can also fork the repo and use it and add some code to debug this on your end

# Gemfile
gem 'knapsack_pro', github: 'KnapsackPro/knapsack_pro-ruby', branch: ‘master’

from knapsack_pro-ruby.

In our before_queue block, we call a rake task which seeds are test data. All tests are being run, but on the nodes that fail, the rake task isn't run and so we have no test data and our rspec tests all fail.

I send over our private build information to your Twitter account.

We setup the KnapsackPro before_queue call once in our rails_helper.rb.

from knapsack_pro-ruby.

I've checked your message on Twitter.

Do you require 'rails_helper.rb' at the beginning of the file spec/models/generation_report_spec.rb?

Can you send full txt output from CI node that did not run the hook. Can you also send output for CI node that did successfully run the hook.
Please send it to [email protected]

The more data I have the bigger chance I can make a better guess what's the root problem. I did not see such a problem before with hooks.

Can you also share your CI config? How do you run knapsack_pro command - once or many times on the Ci node? I'd like to see what's the command called on CI. Thanks.

from knapsack_pro-ruby.

Closing because of no activity in this thread.

from knapsack_pro-ruby.