Comments (9)
Hi @ArturT , sorry for the radio silence. It's not been happening at all since my last update. Two things have changed, the first is probably the issue:
- I moved the
KnapsackPro::Adapters::RSpecAdapter.bind
to spec/spec_helper.rb (it was perviously in another helper that is only loaded for system tests), - the other is we're now using GitHub Actions for CI, rather than Heroku CI.
from knapsack_pro-ruby.
@GeoffTidey Thank you for providing solution to your issue.
@AnkeshThakur Could you ensure KnapsackPro::Adapters::RSpecAdapter.bind
is in spec/spec_helper.rb
?
You could also update the knapsack_pro gem to the latest version. We released a couple of improvements.
I'd appreciate an update from you. If it's no longer a relevant issue, please let me know.
from knapsack_pro-ruby.
@ArturT apology for silence. I'm no longer integrating KnapsackPro. For me older version (<7.0.0) worked without issue.
I have not updated it to later version to check if 7+ versions are working or not.
from knapsack_pro-ruby.
I'm seeing the same issue with instance_double
intermittently with v7
e.g/
Failure/Error: meh = instance_double(MyClass, this_does_exist: 42)
the MyClass class does not implement the instance method: this_does_exist
Just in case it's not obvious, the instance method does exist :)
from knapsack_pro-ruby.
Could you prepare an integration test like this one to help us reproduce an issue?
Or it could be a new Rails app that we could use to debug it?
Thank you.
from knapsack_pro-ruby.
Hi @ArturT do you mean something like https://github.com/KnapsackPro/knapsack_pro-ruby/pull/247/files ?
from knapsack_pro-ruby.
@GeoffTidey Yes.
I've run this test and it's passing successful.
➜ knapsack_pro-ruby git:(pr/247) rspec spec/integration/runners/queue/rspec_runner_spec.rb:382
Resolving dependencies...
Run options: include {:locations=>{"./spec/integration/runners/queue/rspec_runner_spec.rb"=>[382]}}
Randomized with seed 65516
KnapsackPro::Runners::Queue::RSpecRunner - Integration tests
when rails_helper file exists
requires the rails_helper file when running RSpec and runs hooks defined within it
Finished in 0.2351 seconds (files took 0.42629 seconds to load)
1 example, 0 failures
Randomized with seed 65516
We need to prepare a test that would fail with the same error as you see in your project. Then we could prepare a fix for that.
Are you able to identify what is causing the error in your project?
from knapsack_pro-ruby.
Afraid not. It's intermittent.
from knapsack_pro-ruby.
I use the following loop to run test as long until it fails but it is successful. I'm not able to reproduce the issue.
while bundle exec rspec "spec/integration/runners/queue/rspec_runner_spec.rb:382"; do :; done
I use ruby 3.2.3 (2024-01-18 revision 52bb2ac0a6) [arm64-darwin22].
I tried to reproduce it on an older RSpec version without success:
# source Gemfile.lock in the knasack_pro gem
rspec (3.11.0)
rspec-core (~> 3.11.0)
rspec-expectations (~> 3.11.0)
rspec-mocks (~> 3.11.0)
rspec-core (3.11.0)
rspec-support (~> 3.11.0)
rspec-expectations (3.11.0)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.11.0)
rspec-its (1.3.0)
rspec-core (>= 3.0.0)
rspec-expectations (>= 3.0.0)
rspec-mocks (3.11.1)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.11.0)
rspec-support (3.11.0)
rspec_junit_formatter (0.6.0)
rspec-core (>= 2, < 4, != 2.12.0)
I also tried to use the latest gems, but I'm not able to reproduce the issue:
rspec (3.13.0)
rspec-core (~> 3.13.0)
rspec-expectations (~> 3.13.0)
rspec-mocks (~> 3.13.0)
rspec-core (3.13.0)
rspec-support (~> 3.13.0)
rspec-expectations (3.13.0)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-its (1.3.0)
rspec-core (>= 3.0.0)
rspec-expectations (>= 3.0.0)
rspec-mocks (3.13.0)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-support (3.13.1)
rspec_junit_formatter (0.6.0)
rspec-core (>= 2, < 4, != 2.12.0)
@GeoffTidey Could you provide your Ruby and dependency versions? It will help pinpoint what differs between our setups.
from knapsack_pro-ruby.
Related Issues (20)
- Running queue mode locally for troubleshooting with a small subset of tests, but with multiple batches HOT 6
- Does `rake knapsack_pro:rspec_test_example_detector` need to run if there aren't any slow specs? HOT 2
- Slow test analysis runs even when there's no slow tests HOT 2
- Disable example_status_persistence_file_path HOT 3
- Create a replication command on failed node HOT 2
- Incompatibility with rspec --options on 6.0+ HOT 11
- NoMethodError: undefined method `rspec_is_quitting' HOT 2
- NoMethodError: undefined method `rspec_is_quitting' for RSpec::Core::World HOT 1
- After upgrading to minitest 5.22.0 I get error status even if all test pass HOT 8
- NoMethodError: undefined method `keys' for nil HOT 20
- DataDog dropping RSpec tests with the knapsack_pro 7.x gem in Queue Mode HOT 1
- Knapsack v7 ignores run options defined in spec_helpers. HOT 3
- Ruby 3.3 support? HOT 4
- Simplecov doesnt work with Knapsack Pro 7.4 and minitest HOT 16
- Improve handling of skipped tests and dynamic parallelism HOT 12
- knapsack_pro 7.6.1 fails with RSpec HOT 3
- Custom minitest reporter is run once on the first split, twice on the second, ..., N times on the Nth split HOT 1
- feature request: fail fast across nodes HOT 12
- Infinite recursion when KNAPSACK_PRO_LOG_LEVEL is set to debug HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from knapsack_pro-ruby.