Problem Currently, if you are iterating on the ekb control plane

To approach this issue, a function similar to <div class="Box Box--condensed my-2"

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Add deploy-control-plane command to `hack/run.sh` about eventing-kafka-broker HOT 5 OPEN

Cali0707 commented on July 17, 2024

Add deploy-control-plane command to `hack/run.sh`

from eventing-kafka-broker.

Comments (5)

Sanskarzz commented on July 17, 2024 2

/assign

from eventing-kafka-broker.

pierDipi commented on July 17, 2024 1

/triage accepted

If you could give more pointers this could be a good first-good-issues

from eventing-kafka-broker.

Cali0707 commented on July 17, 2024

To approach this issue, a function similar to

eventing-kafka-broker/test/e2e-common.sh

Lines 128 to 147 in 0ed108c

 function build_components_from_source() { 

 [ -f "${EVENTING_KAFKA_CONTROL_PLANE_ARTIFACT}" ] && rm "${EVENTING_KAFKA_CONTROL_PLANE_ARTIFACT}" 

 [ -f "${EVENTING_KAFKA_SOURCE_ARTIFACT}" ] && rm "${EVENTING_KAFKA_SOURCE_ARTIFACT}" 

 [ -f "${EVENTING_KAFKA_BROKER_ARTIFACT}" ] && rm "${EVENTING_KAFKA_BROKER_ARTIFACT}" 

 [ -f "${EVENTING_KAFKA_SINK_ARTIFACT}" ] && rm "${EVENTING_KAFKA_SINK_ARTIFACT}" 

 [ -f "${EVENTING_KAFKA_CHANNEL_ARTIFACT}" ] && rm "${EVENTING_KAFKA_CHANNEL_ARTIFACT}" 

 [ -f "${EVENTING_KAFKA_POST_INSTALL_ARTIFACT}" ] && rm "${EVENTING_KAFKA_POST_INSTALL_ARTIFACT}" 

 header "Data plane setup" 

 data_plane_setup || fail_test "Failed to set up data plane components" 

 header "Control plane setup" 

 control_plane_setup || fail_test "Failed to set up control plane components" 

 header "Building Monitoring artifacts" 

 build_monitoring_artifacts || fail_test "Failed to create monitoring artifacts" 

 return $? 

 }

should be created in the same file, except it should only remove/call setup functions for the control plane and monitoring artifacts.

Then, ./hack/run.sh should be updated to have a new option for deploy-control-plane by adding the option to the list here

eventing-kafka-broker/hack/run.sh

Lines 9 to 42 in 0ed108c

 function usage() { 

 cmd="$1" 

 echo "" 

 echo "Usage for more information read DEVELOPMENT.md" 

 echo "$cmd <command>" 

 echo "" 

 echo "command:" 

 echo " deploy-infra Deploy eventing, Kafka (Strimzi), publish test images" 

 echo " teardown-infra Remove eventing, Kafka (Strimzi)" 

 echo " deploy-kafka Deploy Kafka (Strimzi)" 

 echo " deploy Deploy eventing-kafka-broker" 

 echo " deploy-loom Deploy eventing-kafka-broker with loom modules" 

 echo " deploy-source Deploy eventing-kafka-broker source bundle" 

 echo " teardown Remove eventing-kafka-broker" 

 echo " teardown-source Remove eventing-kafka-broker source bundle" 

 echo " unit-tests, unit-test Run unit tests" 

 echo " unit-tests-data-plane, unit-test-data-plane Run data-plane unit tests" 

 echo " unit-tests-control-plane, unit-test-control-plane Run control-plane unit tests" 

 echo " build-tests-control-plane, build-test-control-plane Run build tests" 

 echo " deploy-sacura Deploy sacura job" 

 echo " sacura-test Run sacura tests" 

 echo " teardown-sacura Remove sacura job" 

 echo " deploy-chaos Deploy chaosduck" 

 echo " teardown-chaos Remove chaosduck" 

 echo " profiler Run profiling tests" 

 echo " generate Run code generators" 

 echo " build-from-source Build artifacts from source" 

 echo " build-for-source-from-source Build artifacts from source for source bundle only" 

 echo " benchmark-filter <bencmark_class_name> Run the filter benchmarks for <benchmark_class_name>" 

 echo " benchmark-filters Run all the filter benchmarks" 

 echo " integration-test <testname> <testdir> Run all e2e tests matching testname in testdir" 

 echo "" 

 }

And finally, the option should be added to the large if else block lower in ./hack/run.sh, where ./test/e2e-common.sh should be sourced and the new function you created called.

from eventing-kafka-broker.

Cali0707 commented on July 17, 2024

/good-first-issue

from eventing-kafka-broker.

knative-prow commented on July 17, 2024

@Cali0707:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from eventing-kafka-broker.

Add deploy-control-plane command to `hack/run.sh` about eventing-kafka-broker HOT 5 OPEN

Comments (5)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	function build_components_from_source() {

	[ -f "${EVENTING_KAFKA_CONTROL_PLANE_ARTIFACT}" ] && rm "${EVENTING_KAFKA_CONTROL_PLANE_ARTIFACT}"
	[ -f "${EVENTING_KAFKA_SOURCE_ARTIFACT}" ] && rm "${EVENTING_KAFKA_SOURCE_ARTIFACT}"
	[ -f "${EVENTING_KAFKA_BROKER_ARTIFACT}" ] && rm "${EVENTING_KAFKA_BROKER_ARTIFACT}"
	[ -f "${EVENTING_KAFKA_SINK_ARTIFACT}" ] && rm "${EVENTING_KAFKA_SINK_ARTIFACT}"
	[ -f "${EVENTING_KAFKA_CHANNEL_ARTIFACT}" ] && rm "${EVENTING_KAFKA_CHANNEL_ARTIFACT}"
	[ -f "${EVENTING_KAFKA_POST_INSTALL_ARTIFACT}" ] && rm "${EVENTING_KAFKA_POST_INSTALL_ARTIFACT}"

	header "Data plane setup"
	data_plane_setup \|\| fail_test "Failed to set up data plane components"

	header "Control plane setup"
	control_plane_setup \|\| fail_test "Failed to set up control plane components"

	header "Building Monitoring artifacts"
	build_monitoring_artifacts \|\| fail_test "Failed to create monitoring artifacts"

	return $?
	}

	function usage() {
	cmd="$1"

	echo ""
	echo "Usage for more information read DEVELOPMENT.md"
	echo "$cmd <command>"
	echo ""
	echo "command:"
	echo " deploy-infra Deploy eventing, Kafka (Strimzi), publish test images"
	echo " teardown-infra Remove eventing, Kafka (Strimzi)"
	echo " deploy-kafka Deploy Kafka (Strimzi)"
	echo " deploy Deploy eventing-kafka-broker"
	echo " deploy-loom Deploy eventing-kafka-broker with loom modules"
	echo " deploy-source Deploy eventing-kafka-broker source bundle"
	echo " teardown Remove eventing-kafka-broker"
	echo " teardown-source Remove eventing-kafka-broker source bundle"
	echo " unit-tests, unit-test Run unit tests"
	echo " unit-tests-data-plane, unit-test-data-plane Run data-plane unit tests"
	echo " unit-tests-control-plane, unit-test-control-plane Run control-plane unit tests"
	echo " build-tests-control-plane, build-test-control-plane Run build tests"
	echo " deploy-sacura Deploy sacura job"
	echo " sacura-test Run sacura tests"
	echo " teardown-sacura Remove sacura job"
	echo " deploy-chaos Deploy chaosduck"
	echo " teardown-chaos Remove chaosduck"
	echo " profiler Run profiling tests"
	echo " generate Run code generators"
	echo " build-from-source Build artifacts from source"
	echo " build-for-source-from-source Build artifacts from source for source bundle only"
	echo " benchmark-filter <bencmark_class_name> Run the filter benchmarks for <benchmark_class_name>"
	echo " benchmark-filters Run all the filter benchmarks"
	echo " integration-test <testname> <testdir> Run all e2e tests matching testname in testdir"
	echo ""
	}