Comments (10)
Yes. With the gotcha that kn version
is broken (we need to propagate ldflags to ko) --> #257
from client.
It'd be great to get nightly-built images tagged with the latest commit SHA (or just :latest
), and release-tagged images built during releases.
from client.
We can directly run the command "ko publish github.com/knative/client/cmd/kn -B -t ${tag}" to name the image <KO_DOCKER_REPO>/kn in the image registry. No need of crane copy.
We can define <KO_DOCKER_REPO> as gcr.io/[gcloud-project], docker.io/, etc. So where do we put this image officially for knative client? Do we have a public directory somewhere to host knative images?
from client.
I have succeeded in creating the image in my own dockerhub repository, docker.io/houshengbo/kn:latest, with the command:
ko publish github.com/knative/client/cmd/kn -B -t latest
When I pulled the image, and did the taskrun run for the following section:
steps
- name: kn-deploy-image
image: docker.io/houshengbo/kn:latest
command: ['kn', 'service', 'create', 'foo', '--image', 'gcr.io/knative-samples/helloworld-go', '--env', 'TARGET=Knative']
I have got:
Error executing command: exec: "kn": executable file not found in $PATH
I was wondering what I have done wrong or I am missing. @imjasonh Do you have any ideas? Thx.
from client.
@houshengbo just shot in the dark, but could you use ./kn
instead of plain kn
? Thoug, I'm not sure what working directory ko
sets for the generated image, nor what working directory Tekton is using.
from client.
It looks like I need to install crane first to check the path of kn. This is what I have done:
go get github.com/google/go-containerregistry/cmd/crane
crane should be install under $GOPATH/bin.
Then run
crane config ${image}
Here is the output for the image of kn:
{"architecture":"amd64","author":"Bazel","created":"1970-01-01T00:00:00Z","history":[{"author":"Bazel","created":"1970-01-01T00:00:00Z","created_by":"bazel build ..."},{"created":"0001-01-01T00:00:00Z"},{"created":"0001-01-01T00:00:00Z"}],"os":"linux","rootfs":{"type":"layers","diff_ids":["sha256:01092e5921c5543a918d54d9df752ee09a84c912a1d914b7eb37e7152f20b951","sha256:8f8d58d9708807553434fbd82014ea40b5ee0dc8b2eeefcde561a363461d3e66","sha256:0d411545791d984190d7488cad58d30fa9ae1aec52eda3262d65ecd1aa58d1dc"]},"config":{"AttachStderr":false,"AttachStdin":false,"AttachStdout":false,"Cmd":null,"Healthcheck":null,"Domainname":"","Entrypoint":["/ko-app/kn"],"Env":["PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin","SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt","KO_DATA_PATH=/var/run/ko"],"Hostname":"","Image":"","Labels":null,"OnBuild":null,"OpenStdin":false,"StdinOnce":false,"Tty":false,"User":"","Volumes":null,"WorkingDir":"","ExposedPorts":null,"ArgsEscaped":false,"NetworkDisabled":false,"MacAddress":"","StopSignal":"","Shell":null},"container_config":{"AttachStderr":false,"AttachStdin":false,"AttachStdout":false,"Cmd":null,"Healthcheck":null,"Domainname":"","Entrypoint":null,"Env":null,"Hostname":"","Image":"","Labels":null,"OnBuild":null,"OpenStdin":false,"StdinOnce":false,"Tty":false,"User":"","Volumes":null,"WorkingDir":"","ExposedPorts":null,"ArgsEscaped":false,"NetworkDisabled":false,"MacAddress":"","StopSignal":"","Shell":null}}
The most important thing we need to look up is Entrypoint":["/ko-app/kn"], which tells us the path of the command.
I will try /ko-app/kn instead of kn to see how it goes. Thanks to @imjasonh.
from client.
/assign @houshengbo
from client.
@houshengbo: GitHub didn't allow me to assign the following users: houshengbo.
Note that only knative members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide
In response to this:
/assign @houshengbo
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from client.
We have it now!
from client.
That's gcr.io/knative-releases/github.com/knative/client/cmd/kn
correct?
from client.
Related Issues (20)
- Ability to set toleration, affinity and node selector HOT 8
- 48h Knative - A Hackathon-Style Event
- Remove deprecated `--inject-broker` flag from `trigger` cmds HOT 1
- Upgrade deprecated v1alpha1 DomainMapping API to newer one HOT 5
- Distinguish missing Serving/Eventing API from unsupported version HOT 8
- Fix shellcheck warnings in hack/build.sh script HOT 1
- Update plugin development docs HOT 5
- Can not get my broker through `kn broker list` HOT 6
- [48h Knative] KServe plugin HOT 4
- Align GVK format accepted by `--channel` flag HOT 12
- Flaky E2E test: e2e/TestDomain - create domain with TLS HOT 9
- Wrong version for kn create kafka channel HOT 7
- Add integration tests for all command usage examples in the binary HOT 5
- [48h Knative] Annotation and Label profiles HOT 1
- [48h Knative] Color output HOT 3
- [48h Knative] UX Evaluation HOT 9
- [48h Knative] Kamelet Sinks HOT 2
- [48h Knative] Command Usage Example Integration Testing POC HOT 3
- [48h Knative] Improved Logging HOT 7
- [48h Knative] Good first issues HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from client.