SigMD5 ending in zeroes are truncated about go-rpmdb HOT 6 CLOSED

I think bytes.TrimRight should be replaced with bytes.TrimSuffi. I welcome contributions 👍
https://github.com/DmitriyLewen/go-rpmdb/blob/801cdbd76e632491a3be72951364749fffce5ca5/pkg/package.go#L237

from go-rpmdb.

I think bytes.TrimRight should be replaced with bytes.TrimSuffi. I welcome contributions 👍 https://github.com/DmitriyLewen/go-rpmdb/blob/801cdbd76e632491a3be72951364749fffce5ca5/pkg/package.go#L237

I don't think bytes.TrimSuffix would work either. MD5 checksums are always 16 bytes in size so any trimming would result in incomplete data.

from go-rpmdb.

It's terminated with null. Or isn't there null as it's not string?

from go-rpmdb.

Yea, I don't think there is a null since it is not a string. I checked the length of the byte slice and it is 16 bytes. So, that doesn't leave room for a null terminator since an MD5 checksum needs 16 bytes.

But, I could see doing something like ie.Data[0:16] in case there was one in some future version of the RPM spec.

from go-rpmdb.

OK

from go-rpmdb.

#45

from go-rpmdb.