Giter VIP home page Giter VIP logo

Comments (4)

Yugloocamai avatar Yugloocamai commented on July 2, 2024

Having this exact issue. Middleware should be configurable to be hierarchical.

from mount.

jbemmel avatar jbemmel commented on July 2, 2024

It's more than just app.context, mounting bypasses all context initialization performed at https://github.com/koajs/koa/blob/master/lib/application.js#L175

Try sending a request over https:// to a mounted app, and checking ctxt.request.secure

This module fundamentally breaks Koa, it is incompatible. When mounting Koa applications https://github.com/koajs/mount#mounting-applications, it should use callback() to make sure the correct processing happens (at https://github.com/koajs/mount/blob/master/index.js#L36)

from mount.

pke avatar pke commented on July 2, 2024

@jbemmel can you provide a PR?

from mount.

jbemmel avatar jbemmel commented on July 2, 2024

Hi Philipp,
In my opinion the problem is with Koa - it has a complex implicit structure that is non-intuitive, and module writers easily get things wrong. I have decided that Koa is not something I want to invest in

from mount.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.