Comments (11)
finished module:
module.exports = function (thingie, callback) {
var socket = thingie.socket || thingie
var res = thingie.res || thingie
if (!socket.writable)
return setImmediate(callback)
socket.on('error', done)
socket.on('close', done)
res.on('finish', done)
function done(err) {
socket.removeListener('error', done)
socket.removeListener('close', done)
res.removeListener('finish', done)
callback(err)
}
return thingie
}
from onerror.
https://github.com/joyent/node/blob/master/lib/net.js#L461
var isException = exception ? true : false;
this._handle.close(function() {
debug('emit close');
self.emit('close', isException);
});
from onerror.
err in callback(err)
is false
, not instance of Error?
from onerror.
when socket close event emit, err is a Boolean
from onerror.
hmmm. ping @jonathanong
from onerror.
i think it should fixed in finished
from onerror.
thingie.socket is ctx.socket, but why we need to listen error and close event?
from onerror.
Already fixed this in latest finished
from onerror.
same as jshttp/on-finished#1
close by jshttp/on-finished@8b2baaa
from onerror.
@jonathanong Also need to update koa deps: finished: '~1.1.3'
from onerror.
is that really necessary? semver can do the work
from onerror.
Related Issues (16)
- ability to use something other than swig, like nunjucks? or is this module outdated? HOT 7
- how do you set the error response to json? HOT 2
- use node 6.7 ζη€ΊοΌ
- Support async render
- No way to get the original *non-error thrown* message HOT 2
- onerror(app,{status:500,mesage:'interval error'}) is disabled HOT 2
- how to configure return json format HOT 2
- How to set up json for response error messages. HOT 2
- How to response json when error happens? HOT 1
- nodejs.Error: non-error HOT 3
- emit error to app.error event listenter HOT 1
- @types/koa-error HOT 1
- How can I customize my own error message
- Swig throws in strict mode HOT 1
- 404 page not work HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from onerror.