Message Dialog (textviewer) issue? about script.skin.helper.service HOT 14 CLOSED

Weird!... without the quotes in some addons it works properly and in some it's not!

I've checked the skins in Krypton Kodi addon repo.
Aeon Nox it's not working and Mimic is working fine.
I think it depends on the size of text that is displayed so i guess this is a bug ?

from script.skin.helper.service.

It's a escaping issue of Kodi. Use this instead:
RunScript(script.skin.helper.service,action=textviewer,header='$ESCINFO[ListItem.Label]',message='$ESCINFO[ListItem.AddonNews]')

The '' and $ESCINFO/$ESCVAR are important.

from script.skin.helper.service.

Well, with the '' and $ESCINFO/$ESCVAR it works properly but still the quotes are showing in textviewer.
Is this how it suppose to work ?... because if it is, is very annoying! @marcelveldt ?

from script.skin.helper.service.

The problem does not exist if you use Phil's toolbox.

@marcelveldt
Maybe you should check his implementation

from script.skin.helper.service.

OK, will do. Sorry for the late reply. Hard for me to follow both the forums and github for issues

from script.skin.helper.service.

@marcelveldt
I've fix this by editing the code in main_module.py

It just needs to replace this code:

if bodytxt.startswith(" "):
  bodytxt = bodytxt[1:]
if headertxt.startswith(" "):

... with this one:

if bodytxt.startswith("'"):
    bodytxt = bodytxt[1:-1]
if bodytxt.startswith('"'):
    bodytxt = bodytxt[1:-1]
if headertxt.startswith(" "):

I have no idea if this is the proper way to do it but it works fine. You know better.
Sorry but i am not so familiar with the pull requests stuff so to make one for this.

Cheers
Nessus

from script.skin.helper.service.

thanks for finding the solution. I will update the code with your proposed changes

from script.skin.helper.service.

@marcelveldt
You've added this for the YesNo & Ok dialogs.
It was needed for the Textviewer dialog (it's on the title of the issue).

PS. Dunno if its also needed for YesNo & Ok dialogs

from script.skin.helper.service.

@marcelveldt
Can i gently bump on this!
I am planning to submit my skin to official repo and wanted all to work properly.

Thanks
Nessus

from script.skin.helper.service.

Sorry for the late reponses... Been busy with family stuff lately and work.

I am catching up with some requests and bugfixes this week and after that I will submit an update to the repo.

from script.skin.helper.service.

@marcelveldt
bump?

I have commented this here... 7673e20#diff-6cd6906a88953a03489b1002f6ecb34dR617

from script.skin.helper.service.

Finally had the chance to fix this. I submitted the new code just now on Git. Can you test it with some scenarios please ?

from script.skin.helper.service.

Working fine now in all places.
Thanks

from script.skin.helper.service.

OK, great! Thanks for testing. I will submit updates to the Kodi repo at the end of this week.

from script.skin.helper.service.