Extract destroy from the PresenterHelper. about nucleus HOT 3 CLOSED

Hi, what are PresenterHelper specific tasks? :)
For me this class looks like a collection of shortcuts to not bloat views.
This is why it keeps a reference to an activity.
Do you have a clearer definition for it?

from nucleus.

My thought was that, aside from the activity reference, this class is a really easy drop-it-anywhere helper for managing a presenter instance. User's can drop it in any type of class they want to have a managed presenter in, and all of the null safety checks and PresenterManager logic is abstracted.

The problem I see with helper keeping a reference to the activity and managing destroy based on that, is that that's the single piece of this class that prevents it from being general use. As an example, some project I've inherited use a single Activity model, where all navigation is done using Fragment transactions. The current PresenterHelper would be of no use there since if presenters were only destroyed when the Activity was finishing, they would never be destroyed until you leave the app.

What I would like to see is the activity.isFinishing() moved up to the Nucleus[Activity|Fragment|Layout] base classes as default functionality, thereby making the PresenterHelper a generally reusable class.

I think it's a fairly simple change, and I'm happy to make it if you agree, just wanted to open this ticket to foster discussion.

from nucleus.

This change will bloat existing classes to some degree, but the ability to reuse the helper looks good. OK.

from nucleus.