null bundle onCreate about nucleus HOT 10 CLOSED

Hello,

No, I'm not aware of such issue. I have a test that ensures that such issue does not exist and RxPresenter works well on production. Do you have an example that can reproduce this behavior?

from nucleus.

@konmik I'll test again tomorrow and follow up you with more info. Basically is a RxPresenter that has a Dagger2 module injected after onTakeView. I will take a better look to provide more useful informations about this.
Thanks!

from nucleus.

I typically get such kind of errors when my View's onSave/onRestore is not properly overloaded.

from nucleus.

@konmik what did you mean with this?

I've checked now and seems that presenter state comes to my fragment, but the presenter doesn't receive that bundle.

I create a gist with the sample of code here:
https://gist.github.com/cavarzan/597b6c618b1f9f339f0d

from nucleus.

I never used ViewPager, but if a fragment gets its bundle, then the presenter should also get its bundle.

Here is an example of NucleusFragment usage: (https://github.com/konmik/nucleus/tree/master/nucleus-example-with-fragments)

What your BasePresenterFragment does? Does it override onCreate/onSaveInstanceState? This is how I usually get my errors of such kind - by improperly overriding these methods. :)

from nucleus.

@konmik The BasePresenterFragment doesn't override those methods.
I've fixed a error in ViewPager that was recreating all fragments. I think it solved.
The thing now is onCreate(Bundle savedState) in Presenter is not called after orientation changes.
I double check your example but I can't see anything that I'm missing =(

from nucleus.

Or onCreate is called once and I need to check the state in onTakeView ?

from nucleus.

onCreate is called once. This is why we use MVP. :) Another time we have it run is only in the case of process restart.

You normally do not need to override onTakeView() - register restartables during onCreate and call them when needed.

from nucleus.

Nice! I think this issue can be closed now. Thanks a lot for your patience.
I using onTakeView() now for inject dagger dependencies, since I need the view to call getComponent and inject the presenter.

from nucleus.

The best place for dependencies injection is PresenterPactory, see Ryan's and my answers in #12 (comment)

from nucleus.