Null safety support about connectanum-dart HOT 11 CLOSED

@konsultaner I'm not currently doing Dart stuff .. test quickly. OP might .. actually I don't know

from connectanum-dart.

@oberstet ok, thank you! I'll merge it. Upcoming issues will be posted anyways. . So What 🤔

from connectanum-dart.

I thought about it and found out that at the moment not all deps have nullsafty yet. I will start working at this as soon as all deps are nullsafe.

from connectanum-dart.

Dependencies:
pointycastle: Prerelease: 3.0.0-nullsafety.2
logging: 1.0.0 null safe
pedantic: 1.11.0 null safe
meta: 1.3.0 null safe
msgpack_dart: 1.0.0 null safe
saslprep is your package @konsultaner as far as i understand. So looks like that all main dependencies are nulls safe.

Also both dev dependencies are null safe.

from connectanum-dart.

Seems like I have to start earlier then I thought. The problem I saw was bouncy castle. It kind of stopped development. Seems like they have continued there work. Thanks for checking my deps ✌️

from connectanum-dart.

@konsultaner I have created new PR (#31) regarding this issue. Hope it will help to speed up development. :)

from connectanum-dart.

Oh cool Thanks! What happened to the code coverage? Did you remove Tests?

from connectanum-dart.

Oh cool Thanks! What happened to the code coverage? Did you remove Tests?

To be honest i don't know what is reason. I rewrited code, to use null safety logic. That involved a lot of null checks. Possibly some of that was reason, why coverage rating decreased.

from connectanum-dart.

Oh cool Thanks! What happened to the code coverage? Did you remove Tests?

Maybe you can try to take a look. when you have time. But no rush.

from connectanum-dart.

@andzejsw @oberstet Could someone confirm https://github.com/konsultaner/connectanum-dart/tree/sound-null-safety does work in production? I would like to finally support sound null safety.

from connectanum-dart.

@konsultaner cool, thanks for moving things forward!

btw, as we are talking here, and rgd the way forward with WAMP/Crossbar.io etc, you might be interested in wamp-proto/wamp-proto#387

from connectanum-dart.