Giter VIP home page Giter VIP logo

Comments (7)

nicman23 avatar nicman23 commented on June 12, 2024 1

sorry i meant moved to lib/math/cordic.c from lib/cordic.c

and so it had to be deleted from /lib/Makefile

from bcachefs.

eadwu avatar eadwu commented on June 12, 2024 1

Can confirm it works fine in 5.2.6. Only change are without the migrate_page_move_mapping parameter being removed since it isn't in the stable kernel yet.

For the patch it would probably be better to remove the new generic_file_buffered_read change since it'll be present after the rebase.

from bcachefs.

eadwu avatar eadwu commented on June 12, 2024

Not sure about whether or not cordic.c was actually removed?

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/lib/math/cordic.c?h=v5.3-rc3

from bcachefs.

nicman23 avatar nicman23 commented on June 12, 2024

just to reiterate this is for 5.3 and i have not tested it in 5.2

also for generic_file_buffered_read yes i might have messed that up. oh well, it is unused

from bcachefs.

nicman23 avatar nicman23 commented on June 12, 2024

updated - on par with master

from bcachefs.

eadwu avatar eadwu commented on June 12, 2024

The [failed] trivial patch for 5.5 which fails with some closure symbols being missing

diff --git a/fs/bcachefs/checksum.c b/fs/bcachefs/checksum.c
index 6f1afa4a3119..5ece98fe7d01 100644
--- a/fs/bcachefs/checksum.c
+++ b/fs/bcachefs/checksum.c
@@ -13,6 +13,7 @@
 #include <crypto/chacha.h>
 #include <crypto/hash.h>
 #include <crypto/poly1305.h>
+#include <crypto/internal/skcipher.h>
 #include <keys/user-type.h>
 
 static u64 bch2_checksum_init(unsigned type)
diff --git a/fs/bcachefs/journal.h b/fs/bcachefs/journal.h
index ec61137df00a..f0da2c52581c 100644
--- a/fs/bcachefs/journal.h
+++ b/fs/bcachefs/journal.h
@@ -269,7 +269,7 @@ static inline void bch2_journal_res_put(struct journal *j,
 	if (!res->ref)
 		return;
 
-	lock_release(&j->res_map, 0, _THIS_IP_);
+	lock_release(&j->res_map, _THIS_IP_);
 
 	while (res->u64s)
 		bch2_journal_add_entry(j, res,
diff --git a/kernel/locking/six.c b/kernel/locking/six.c
index 9fa58b6fadc9..c778123505d0 100644
--- a/kernel/locking/six.c
+++ b/kernel/locking/six.c
@@ -15,7 +15,7 @@
 #endif
 
 #define six_acquire(l, t)	lock_acquire(l, 0, t, 0, 0, NULL, _RET_IP_)
-#define six_release(l)		lock_release(l, 0, _RET_IP_)
+#define six_release(l)		lock_release(l, _RET_IP_)
 
 struct six_lock_vals {
 	/* Value we add to the lock in order to take the lock: */
Kernel: arch/x86/boot/bzImage is ready  (#1)
ERROR: "closure_sub" [drivers/md/bcache/bcache.ko] undefined!
ERROR: "__closure_wake_up" [drivers/md/bcache/bcache.ko] undefined!
ERROR: "closure_put" [drivers/md/bcache/bcache.ko] undefined!
ERROR: "__closure_sync" [drivers/md/bcache/bcache.ko] undefined!
ERROR: "closure_wait" [drivers/md/bcache/bcache.ko] undefined!
ERROR: "closure_sub" [fs/bcachefs/bcachefs.ko] undefined!
ERROR: "__closure_wake_up" [fs/bcachefs/bcachefs.ko] undefined!
ERROR: "closure_put" [fs/bcachefs/bcachefs.ko] undefined!
ERROR: "__closure_sync" [fs/bcachefs/bcachefs.ko] undefined!
ERROR: "closure_wait" [fs/bcachefs/bcachefs.ko] undefined!
make[2]: *** [../scripts/Makefile.modpost:94: __modpost] Error 1
make[1]: *** [/build/linux-5.5-rc6/Makefile:1282: modules] Error 2
make: *** [../Makefile:179: sub-make] Error 2

from bcachefs.

eadwu avatar eadwu commented on June 12, 2024

The fix was actually pretty straightforward, I just for some reason never decided to look at the log for closure.c. https://github.com/eadwu/bcachefs/commit/183fcbaaceef5bd32042bbd60954ec4415aeb6a1

from bcachefs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.