Comments (2)
Currently, we put a simple comment (not a suggestion) on the last line of the multiline hint (if it's in the range of the diff). Probably we should consider not only the last line but any, which satisfies the diff?
from hintman.
@vrom911 We can use new GitHub feature for multiline comments to select the whole area. But:
- This is more complicated because it requires more interval and range overlapping checks.
- This feature is in beta now, I'm not even sure there's an API for it...
Commenting on the last line seems good enough for now to me
from hintman.
Related Issues (20)
- Speed up tests by fetching PRs only once
- Add headers to Trailing* hints HOT 1
- Improve README
- Add tests for multiple hints in different hunks
- [RFC] Use multiline comment API to leave multiline comments HOT 2
- Display code duplication HLint suggestions better
- Log HLint errors
- [RFC] Rust support HOT 3
- [RFC] A lint for a lacking newline at the end of file HOT 1
- Investigate `endOfInputError` HOT 1
- Split file contents in the lines only once
- Use the correct base repo for downloading PR sources HOT 6
- Test consistency of `TrailingNewline` and `NoNewlineAtFileEnd`
- Bad credentials error
- Bump up GHC
- Support folders/files ignore
- Instructions how to uninstall HOT 1
- Use HLint 3.0
- Deprecation of some of the GitHub events
- Stylish-haskell and Ormolu support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hintman.