Giter VIP home page Giter VIP logo

Comments (11)

SimonSapin avatar SimonSapin commented on May 30, 2024

I haven’t looked into the details yet, but could you be more specific? Please provide an example (HTML and CSS), explain what is the behavior you expected and what you’re getting instead.

from weasyprint.

mweissen avatar mweissen commented on May 30, 2024

I have tried

<style type="text/css"> td {height: 50px} </style>

But the heigth of the cells did not change.

from weasyprint.

liZe avatar liZe commented on May 30, 2024

Here's a simple example now that heights are handled for tables:
<body><table><tr><td style="background: red; height: 100px; vertical-align: bottom">aaa

from weasyprint.

ewjoachim avatar ewjoachim commented on May 30, 2024

Having the same problem here... If there's at least a workaround, that would be great !

from weasyprint.

SimonSapin avatar SimonSapin commented on May 30, 2024

@ewjoachim Could you give details on what problem exactly you’re having? Please provide an example (HTML and CSS), explain what is the behavior you expected and what you’re getting instead.

from weasyprint.

ewjoachim avatar ewjoachim commented on May 30, 2024

HTML code :

<!DOCTYPE html>
<html>
    <head>
        <meta charset="utf-8" />
        <title></title>
        <style type="text/css">
            td
            {
                height: 50px;
                border: 1px solid red;
                vertical-align: bottom;
            }
        </style>
    </head>

    <body>
        <table>
            <tr><td>Yay</td></tr>
        </table>
    </body>
</html>

(no CSS other than inlined)

Expected : "Yay" should be at the bottom of the cell
What I get instead : "Yay" is at the top (whatever the value of vertical-align)
(maybe my HTML is wrong in the first place, all I can tell is that both Chorme and Firefox got it right)

from weasyprint.

honi avatar honi commented on May 30, 2024

Having the same problem here. Does anybody know if @s31415 fix works? Any plan on merging it?

from weasyprint.

vojkny avatar vojkny commented on May 30, 2024

vertical-align: middle; does not work either.

from weasyprint.

liZe avatar liZe commented on May 30, 2024

I'll take a look at this

from weasyprint.

liZe avatar liZe commented on May 30, 2024

The patch proposed in #214 works for fixed-height rows, but not for fixed-height cells. I'm trying to find a better solution.

from weasyprint.

liZe avatar liZe commented on May 30, 2024

vertical-align was handled for cells with an auto height (ie. adding padding to make it fit in the row), but it was not handled for cells with a fixed height (ie. changing the position of the content in the cell).

f4f8c25 fixes the main common cases (and doesn't break any test). I'm not sure about many corner cases, including:

  • cells with a vertical-align: baseline property
  • cells with a fixed height and a vertical padding
  • cells in fixed-height rows (what #214 is about)

I'll add some tests and fix the bugs I can find. @honi @knyttl : you are welcome to test and find any case that's not working for you!

from weasyprint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.