Rails4 delegate issue about stupidedi HOT 5 CLOSED

The scope of this change might be quite large, since delegate is used in about 80 call sites. My approach would probably be to change the Module#delegate method to a singleton method, like

module Stupidedi
  def self.delegate(klass, *params)
    ...
  end
end

and then change each call site to look like Stupidedi.delegate(self, ...). This approach isn't much more than moving the method to a namespace, where it won't conflict with ActiveSupport.

I'd gladly accept a patch from you to do this, otherwise it may take a while for me to get around to doing it myself, simply because it's a low priority for me. Feel free to ask for help if you're interested in working on it! Solving this would probably solve the most important parts of #23.

from stupidedi.

cool! thx for the quick response, i would like to try this tomorrow

-=K=-

On Tuesday, February 4, 2014 at 8:36 PM, Kvle Putnam wrote:

The scope of this change might be quite large, since delegate is used in about 80 call sites. My approach would probably be to change the Module#delegate method to a singleton method, like
module Stupidedi def self.delegate(klass, *params) ... end end

and then change each call site to look like Stupidedi.delegate(self, ...). This approach isn't much more than moving the method to a namespace, where it won't conflict with ActiveSupport.
I'd gladly accept a patch from you to do this, otherwise it may take a while for me to get around to doing it, simply because it's a low priority for me. Feel free to ask for help if you're interested in working on it! Solving this would probably solve the most important parts of #23 (#23).

—
Reply to this email directly or view it on GitHub (#35 (comment)).

from stupidedi.

I guess fixed this delegate thing by follow your solution, but more issue come out from active_support which prevent me to work on my current rails app. In the meantime, i have to finish something in hurry and i would like to figure this out later.
Thanks a lot for the helps.

from stupidedi.

Hmm, sorry to hear more Rails issues are lurking. If you'll be occupied for a while, I'll happily accept a pull-request that fixed only the issue with delegate. No problem with filing the other issues separately, when you have time.

from stupidedi.

Closing this issue as @irobayna fixed problems with delegate in #41. Please open a new ticket if other problems remain.

from stupidedi.