Build Task fails on windows due to OS separator about makara HOT 10 CLOSED

Grunt uses minimatch.

minimatch says no to backslashes:
https://github.com/isaacs/minimatch/blob/master/minimatch.js#L147

  if (platform === "win32") {
    pattern = pattern.split("\\").join("/")
  }

from makara.

I've been doing some tests on windows and found this:

• https://github.com/paypal/makara/blob/master/lib/fileutil.js#L173 Does not split up the path properly, so it can't locate the common root.

The findCommonRoot function in fileutil is getting a list of files with the separator '/' but uses the separator from path.sep, which is '' on Windows. If you hardcode it to '/' it works well.

from makara.

I've been looking at this issue and have been able to compile the index.dust and the layouts/master.dust templates but not the errors/*.dust templates.
Grunt uses always a slash as a dir separator has @lmarkus noted above, even on Windows but the path module uses the separator from the OS and when on Windows, it automatically changes the slash to backslashes, which causes a big mess.
What I've done was look for the places where it is changing to backslashes and turn into slash and only use backslashes when there is some file read.

from makara.

@lmarkus I can now compile on Windows all dust templates and generate the .js files. The problem is that I still have the 500 error when running node on production mode...

from makara.

Can you point me to the repo where you've been doing the work?

from makara.

I've been doing this locally on my pc but I've forked makara just now so I
can show you what I've been doing. Just a minute :-)

2014-01-27 Lenny Markus [email protected]

Can you point me to the repo where you've been doing the work?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/22#issuecomment-33433277
.

from makara.

https://github.com/AlexSantos/makara/blob/fix-windows-build/tasks/dustjs-i18n.js

2014-01-27 Alexandre Santos [email protected]

I've been doing this locally on my pc but I've forked makara just now so I
can show you what I've been doing. Just a minute :-)

2014-01-27 Lenny Markus [email protected]

Can you point me to the repo where you've been doing the work?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/22#issuecomment-33433277
.

from makara.

@lmarkus , I hope it helped to solve the problem.

from makara.

Fixed via d77202e

from makara.

@alexsantos Part of the solution 😄

from makara.