Giter VIP home page Giter VIP logo

Comments (13)

harouny avatar harouny commented on May 18, 2024 1

Hey @bluepnume

I have done good progress in angular 2 driver this weekend. However something worth a discussion:

Angular team decided at some point to have the following naming:
AngularJs is the name of versions < 2
Angular is the name of verstions >= 2 (currently in version 4 afaik)

In Xcomponent we have angular currently reserved for AngularJs versions < 2

We have the following options for the name of Angular > 2:

  • angular (requires a breaking change to rename existing angular to angularJs)
  • angular2 (will indicate angular 2+)
  • ng (angular team used ng in places where angular was reserved i.e window.angular)

I feel like angular2 is not too bad, but needed other opinions.

from zoid.

dackmin avatar dackmin commented on May 18, 2024 1

I don't want to be that guy but I don't think zoid should natively support a lot of (if any) frameworks, as one might want to use it without any framework without having a 200kbs minimum minified bundle for any of the frames.

External plugins might be a better approach. Any thoughts ?

from zoid.

bluepnume avatar bluepnume commented on May 18, 2024 1

Hi all -- if anyone is interested, just pushed support for shadow dom using slots. This should open the door to more framework support.

from zoid.

davidmathlogic avatar davidmathlogic commented on May 18, 2024

I'd certainly like to see support for Vue.js.

from zoid.

bluepnume avatar bluepnume commented on May 18, 2024

Sounds like a plan 👍

from zoid.

adilmughal avatar adilmughal commented on May 18, 2024

Angular 2+ support please

from zoid.

harouny avatar harouny commented on May 18, 2024

@bluepnume I started a POC for Angular 2.0 support. I know its not as straightforward as the others.
First item done is to have a minimal setup for an angular 2 app in demo/frameworks/angular2 that we can use in dev
https://github.com/harouny/xcomponent/tree/feature/angular2_driver/demo/frameworks/angular2

from zoid.

harouny avatar harouny commented on May 18, 2024

One goal is to not mess up with our package.json etc with Angular 2.0 / Typescript stuff. So everything is compiled/transpiled in browser.

from zoid.

veenasubramanyam avatar veenasubramanyam commented on May 18, 2024

Is there an example or demo of how to embed a react component inside an angular 2 container?

from zoid.

bluepnume avatar bluepnume commented on May 18, 2024

Angular 2.0 isn't yet supported. But you could just do something like this:

https://github.com/krakenjs/xcomponent/tree/master/demo/advanced/react-end-to-end

In index.htm, instead of using React, you could just do MyLoginXComponent.render({ ... }, '#container') inside an angular 2 component.

from zoid.

morbidick avatar morbidick commented on May 18, 2024

Hi @harouny and @bluepnume,
is there any documentation on the api the driver has to provide? For register its more or less clear what has to happen, but what about scan since thats probably the hard part to get shadow dom working with polymer?
Thx in advance!

from zoid.

bluepnume avatar bluepnume commented on May 18, 2024

Hi @morbidick -- sorry I missed your question earlier.

scan is just an implementation detail of the script driver -- I wouldn't worry too much about it. For most drivers register should be enough. Then it's up to the framework to render the component, and to give your driver a clue that it should initialize.

The biggest problem I saw with polymer was when someone was testing it with the paypal button -- paypal/paypal-checkout-components#353 -- since the iframe wasn't accessible in window.frames[name]. But I didn't dig in too deep into that.

from zoid.

edwardchanjw avatar edwardchanjw commented on May 18, 2024

OSS time is precious, If there is real work need to be done. Then the team must focus more important thing.
Since most framework seem to already support. Plugins sound good, and do tree shaking can be done for seperate of React / Angular part? Plugin needed if there is really a popular framework need to added.

Additionally is Custom Elements is able to consider as base and let the framework to work with Custom Elements? I no sure I grasp the concept correctly, or the design would be not compromise to do that?

from zoid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.