Krasa - JAXB : Wrong @Digit validation attribute with totalDigits & fractionDigits (XSD) about krasa-jaxb-tools HOT 16 CLOSED

https://www.safaribooksonline.com/library/view/xml-schema/0596002521/re52.html
"
Description
xs:totalDigits defines the maximum number of digits of decimal and derived datatypes (both after and before the decimal point, not counting the decimal point itself).

This facet constrains the value space, which means that the number of digits is checked after the value is transformed to its canonical form and the leading and trailing zeros are removed.
"

Another example here: http://zvon.org/xxl/XMLSchemaTutorial/Output/ser_types_st3.html
With 10 reserved for the fractional part, that should leave 1 for the whole number part? Which seems to match the generated code?

from krasa-jaxb-tools.

<simpleType name="decimalType">
<restriction base="decimal">
<totalDigits value="3"/>
<fractionDigits value="2"/>
</restriction>
</simpleType>
Valid
123
123.0
123.000
12.3
1.23

Invalid
0.123
12.34
123.1

When decimals are not present then integral part is allowed to have number of digits as 'totalDigits' as per schema. But generated annotation is not going to do that if integer is (totalDigits - fractionDigits) instead totalDigits.

from krasa-jaxb-tools.

Digits supporting "total" (optional) along with integer and fraction will be helpful! But it wont come in the scope of this forum probably.

So even it's not exact fix it's good if we would have Digits:integer as decimal:totalDigits from schema definition?

from krasa-jaxb-tools.

If you can provide a github project demoing the issue I could attempt to fix with a pull-request.
Demo including:
minimal schema
generated bean
showing xsd validation passes
and hibnerate validator does not
or vice versa

from krasa-jaxb-tools.

@davidkarlsen : The github sample for above issue is available at https://github.com/akumar11/KrasaSample

from krasa-jaxb-tools.

@akumar11 Actually there seems to be an error with the test itself - when I fixed the filepaths all tests pass: https://github.com/akumar11/KrasaSample/pulls

from krasa-jaxb-tools.

By changing (correcting) test case com.test.krasa.XsdObjectValidateTest.testXsdObject we can see bug.

Modify line assertEquals(Boolean.FALSE, validateBean(travelInfoData3).isEmpty()); to assertEquals(Boolean.TRUE, validateBean(travelInfoData3).isEmpty()); then there is failure.

from krasa-jaxb-tools.

@davidkarlsen : I prepared the above sample as per Windows Environment. However, you can see @digits validation failure by changing the assertion (line#85) from Boolean.FALSE to Boolean.TRUE ( @mcmoulis explained this well in above comment ) .

from krasa-jaxb-tools.

Any comments/inputs?

from krasa-jaxb-tools.

Should I take a look? :-)

from krasa-jaxb-tools.

@krasa That would be great - I never came along for it.

from krasa-jaxb-tools.

@krasa Did you figure anything out?

from krasa-jaxb-tools.

Well, I agree that there is a bug :-)

I think the best would be to introduce a custom annotation+validator. That would require the plugin to be used also as a compile+runtime dependency (or make a new runtime library for just that, but that would be much more work).
And @digits should not be used when there are fractionDigits in xsd.

from krasa-jaxb-tools.

@krasa Could we not simply apply some simple arithmetics? When defining totalDigits and fractionDigits in the xsd world, leaving total-fraction=integer in the jsr303 world? http://zvon.org/xxl/XMLSchemaTutorial/Output/ser_types_st3.html
http://docs.oracle.com/javaee/6/api/javax/validation/constraints/Digits.html

from krasa-jaxb-tools.

aha - I see it now - that's actually what is happening - but leaves no space for the integral part when in fact no fraction digits are present

from krasa-jaxb-tools.

Super - this issue can be closed and put in the 1.4 milestone! Thanks a lot!

from krasa-jaxb-tools.