Giter VIP home page Giter VIP logo

Comments (10)

chbatey avatar chbatey commented on August 29, 2024

I re-created this, seems the manifest is being lost on deserialisation, checking with the akka dev team

from akka-persistence-cassandra.

chbatey avatar chbatey commented on August 29, 2024

I think this is a bug in the akka persistence default serialiser for PersistentRepr, i changed our code to:

  private def persistentToByteBuffer(persistentRepr: PersistentRepr): ByteBuffer = {
    val bytes = serialization.serialize(persistentRepr).get
    val back = serialization.deserialize(bytes, classOf[PersistentRepr]).get
    require(persistentRepr.manifest == back.manifest)
    ByteBuffer.wrap(bytes)
  }

And it fails.

from akka-persistence-cassandra.

ktoso avatar ktoso commented on August 29, 2024

Thanks for the ping @chbatey! Seems weird, I'll look into it today after some Http work.
Maybe it's some silly mistake as we have payloadManifest and manifest, perpahs our tests were setting up to much manually to catch this hm, I'll report back soon!

from akka-persistence-cassandra.

chbatey avatar chbatey commented on August 29, 2024

Looks like this is fixed in master of akka, will check when we upgrade to 2.4-RC2

from akka-persistence-cassandra.

ktoso avatar ktoso commented on August 29, 2024

Yup, and we'll release the RC2 today to not block you guys with this bug.
Thanks for catching it again.

from akka-persistence-cassandra.

pjan avatar pjan commented on August 29, 2024

Thanks guys!

from akka-persistence-cassandra.

ktoso avatar ktoso commented on August 29, 2024

Hi guys, the fix in Akka has been pushed – please bump to 2.4.0-RC2 👍

from akka-persistence-cassandra.

chbatey avatar chbatey commented on August 29, 2024

Thanks @ktoso works for me, @pjan ?

from akka-persistence-cassandra.

pjan avatar pjan commented on August 29, 2024

can be closed.

from akka-persistence-cassandra.

ktoso avatar ktoso commented on August 29, 2024

Yay :)
On Sep 16, 2015 09:27, "Christopher Batey" [email protected] wrote:

Closed #75
#75.


Reply to this email directly or view it on GitHub
#75 (comment)
.

from akka-persistence-cassandra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.