Giter VIP home page Giter VIP logo

Comments (9)

pmontrasio avatar pmontrasio commented on July 17, 2024

Actually, both gems are yours but the default version is outdated and not in sync with the README.

To help you debug the problem, the gemspec of the outdated gem is https://gist.github.com/pmontrasio/aeb15a618b5f288451bc

The gemspec of the gem I get when including the github option is https://gist.github.com/pmontrasio/2b69a7cd37d35740ef1e

from gmaps-autocomplete-rails.

pmontrasio avatar pmontrasio commented on July 17, 2024

Finally, I noticed this message from bundle with the gem that works

gmaps-autocomplete-rails at /home/me/.rvm/gems/ruby-2.1.2@forever/bundler/gems/gmaps-autocomplete-rails-f9c604cf9d27 did not have a valid gemspec.
This prevents bundler from installing bins or native extensions, but that may not affect its functionality.
The validation message from Rubygems was:
  ["spec/index.html", "spec/init.js", "vendor/assets/javascripts/gmaps-autocomplete.js"] are not files

from gmaps-autocomplete-rails.

kristianmandrup avatar kristianmandrup commented on July 17, 2024

Thanks. I'm excluding the 3 non-existing files from the gemspec and releasing a new official version ASAP.

from gmaps-autocomplete-rails.

kristianmandrup avatar kristianmandrup commented on July 17, 2024

Pushed version 0.1.4. Hope it resolves most of the issues (I'm not using Rails at this point)

Successfully registered gem: gmaps-autocomplete-rails (0.1.4)

from gmaps-autocomplete-rails.

pmontrasio avatar pmontrasio commented on July 17, 2024

Fixed, closing.
Thanks!

from gmaps-autocomplete-rails.

kristianmandrup avatar kristianmandrup commented on July 17, 2024

Great! You are most welcome to fork this gem and take over from where I have left off.
Would be nice to make it more "flexible", f.ex not to be coupled to jquery-ui and have a better class structure instead of the current flat one. Cheers!

from gmaps-autocomplete-rails.

pmontrasio avatar pmontrasio commented on July 17, 2024

You're too kind to me. I don't make promises but I just I forked it to add a 3rd argument to updateUI, to pass the full geocoder response. Thank you for all the good work!

from gmaps-autocomplete-rails.

kristianmandrup avatar kristianmandrup commented on July 17, 2024

I would recommend the following redesign...

Split up the class into these classes:

  • GmapsConfigurator
  • GmapsGeocoder
  • GmapsUI
  • GmapsErrorHandler

Please spend 1-2 hours and see what you come up with ;) Also add a test suite (TDD).
Cheers!

from gmaps-autocomplete-rails.

kristianmandrup avatar kristianmandrup commented on July 17, 2024

Checkout this branch:

https://github.com/kristianmandrup/gmaps-autocomplete-rails/tree/refactor

You are most welcome to work on it if you have time... :)

from gmaps-autocomplete-rails.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.