Comments (9)
Actually, both gems are yours but the default version is outdated and not in sync with the README.
To help you debug the problem, the gemspec of the outdated gem is https://gist.github.com/pmontrasio/aeb15a618b5f288451bc
The gemspec of the gem I get when including the github option is https://gist.github.com/pmontrasio/2b69a7cd37d35740ef1e
from gmaps-autocomplete-rails.
Finally, I noticed this message from bundle with the gem that works
gmaps-autocomplete-rails at /home/me/.rvm/gems/ruby-2.1.2@forever/bundler/gems/gmaps-autocomplete-rails-f9c604cf9d27 did not have a valid gemspec.
This prevents bundler from installing bins or native extensions, but that may not affect its functionality.
The validation message from Rubygems was:
["spec/index.html", "spec/init.js", "vendor/assets/javascripts/gmaps-autocomplete.js"] are not files
from gmaps-autocomplete-rails.
Thanks. I'm excluding the 3 non-existing files from the gemspec and releasing a new official version ASAP.
from gmaps-autocomplete-rails.
Pushed version 0.1.4. Hope it resolves most of the issues (I'm not using Rails at this point)
Successfully registered gem: gmaps-autocomplete-rails (0.1.4)
from gmaps-autocomplete-rails.
Fixed, closing.
Thanks!
from gmaps-autocomplete-rails.
Great! You are most welcome to fork this gem and take over from where I have left off.
Would be nice to make it more "flexible", f.ex not to be coupled to jquery-ui and have a better class structure instead of the current flat one. Cheers!
from gmaps-autocomplete-rails.
You're too kind to me. I don't make promises but I just I forked it to add a 3rd argument to updateUI, to pass the full geocoder response. Thank you for all the good work!
from gmaps-autocomplete-rails.
I would recommend the following redesign...
Split up the class into these classes:
- GmapsConfigurator
- GmapsGeocoder
- GmapsUI
- GmapsErrorHandler
Please spend 1-2 hours and see what you come up with ;) Also add a test suite (TDD).
Cheers!
from gmaps-autocomplete-rails.
Checkout this branch:
https://github.com/kristianmandrup/gmaps-autocomplete-rails/tree/refactor
You are most welcome to work on it if you have time... :)
from gmaps-autocomplete-rails.
Related Issues (14)
- Mistake in README.md HOT 2
- file name of gmaps-autocomplete.js is wrong HOT 6
- My autocomplete list is showing transparently in the form HOT 6
- Put 'gmaps-output-longitude' and 'gmaps-output-latitude' to hidden field HOT 2
- Uncaught ReferenceError and TypeError HOT 3
- How to use Google Places API Key? HOT 1
- Multiple autocomplete fields on the same page does not autocomplete correctly HOT 8
- Can be this gem used without specification of country? HOT 3
- Gem not working with latest gem versions HOT 5
- Docs need to be updated HOT 1
- Uncaught TypeError: Object #<HTMLInputElement> has no method 'geocodeLookup' HOT 4
- Missing include for jquery-ui CSS file in instructions
- Error load pipeline asset HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gmaps-autocomplete-rails.