Week 3 assignment complete / Except offline /ORM support about simpletwitterclient HOT 6 OPEN

/cc @nesquena
1)Implemented Clearable Edit Text, so that user can clear the edit text box
2)Text counter changes color to red after user types over 140
3)Display Home As Up Enabled - via Action Bar for compose
4)User Screen Name on Tweet Time line + profile and screen name on compose
5) Menu driven compose activity navigation for back & submit

from simpletwitterclient.

👍 nice work overall. A few notes after checking out the code:

• Nice to see you used PullToRefresh library
• Good to see you added the tweet to the home timeline after you posted new on compose
• Consider adding the character count for Compose Activity to limit to 140. See this event handler for more details.
• Consider removing BaseModel from Tweet and User and follow this json to model approach instead which doesn't require BaseModel
• Consider adding ActiveAndroid to the Tweet and User. See the persistence guide and this other guide for more details.

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together. We are close to a turning point in the course where you should be hitting a "critical mass" for your Android knowledge.

from simpletwitterclient.

Hey Thanks Nathan,
Consider adding the character count for Compose Activity to limit to 140.
See [ KS] Didn't limit it as twitter compose feature on their site allows
user to add more than 140 characters and turns to red if max length is
reached. I mocked the same behavior.

Also please share your feedback on the extra features I tried out -
1)Implemented Clearable Edit Text, so that user can clear the edit text box
2)Text counter changes color to red after user types over 140
3)Display Home As Up Enabled - via Action Bar for compose (back button)
4)User Screen Name on Tweet Time line + profile and screen name on compose
5) Menu driven compose activity navigation for back & submit

On Wed, Feb 5, 2014 at 12:03 AM, Nathan Esquenazi
[email protected]:

[image: 👍] nice work overall. A few notes after checking out the code:

• Nice to see you used PullToRefresh library
• Good to see you added the tweet to the home timeline after you
  posted new on compose
• Consider adding the character count for Compose Activity to limit to
• See this event handlerhttps://github.com/thecodepath/android_guides/wiki/Basic-Event-Listeners#textchangedlistenerfor more details.
• Consider removing BaseModel from Tweet and User and follow this json
  to modelhttps://github.com/thecodepath/android_guides/wiki/Android-Bootcamp-Cliffnotesapproach instead which doesn't require
  BaseModel
• Consider adding ActiveAndroid to the Tweet and User. See the persistence
  guidehttps://github.com/thecodepath/android_guides/wiki/Persisting-Data-to-the-Device#object-relational-mappersand this other
  guidehttps://github.com/thecodepath/android_guides/wiki/ActiveAndroid-Guidefor more details.

Here's a detailed Project 3 Feedback Guide herehttps://gist.github.com/nesquena/a41220c54c9550f69599which covers the most common issues with this submitted project. Read
through the feedback guide point-by-point to determine how you could
improve your submission.

Let us know if you have any other thoughts or questions about this
assignment. Hopefully by now you feel pretty comfortable with all the major
pieces to basic Android apps (Views, Controllers, Models, Authentication,
API Communication, Preferences, ActionBar, et al) and see how they all fit
together. We are close to a turning point in the course where you should be
hitting a "critical mass" for your Android knowledge.

Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-34144861
.

from simpletwitterclient.

See [ KS] Didn't limit it as twitter compose feature on their site allows
user to add more than 140 characters and turns to red if max length is
reached. I mocked the same behavior.

In the version on github, I didn't see a character counter here https://github.com/krunalsshah/SimpleTwitterClient/blob/master/src/com/codepath/apps/simpletwitterapp/ComposeTweetActivity.java but that behavior you describe sounds correct.

Noticed all your extra features, they all seem like reasonable improvements. Nice work!

from simpletwitterclient.

Please see the counter as part of clearable edit text -
https://github.com/krunalsshah/SimpleTwitterClient/blob/master/res/layout/clearable_edit_text.xml

And its implementation
https://github.com/krunalsshah/SimpleTwitterClient/blob/master/src/com/codepath/apps/simpletwitterapp/ClearableEditText.java

Thanks,
Krunal

On Wed, Feb 5, 2014 at 12:25 AM, Nathan Esquenazi
[email protected]:

See [ KS] Didn't limit it as twitter compose feature on their site allows
user to add more than 140 characters and turns to red if max length is
reached. I mocked the same behavior.

In the version on github, I didn't see a character counter here
https://github.com/krunalsshah/SimpleTwitterClient/blob/master/src/com/codepath/apps/simpletwitterapp/ComposeTweetActivity.javabut that behavior you describe sounds correct.

Noticed all your extra features, they all seem like reasonable
improvements. Nice work!

Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-34145925
.

from simpletwitterclient.

Ah right, thanks! Looks great, nice use of an extended view.

from simpletwitterclient.