(Discuss) Coding Standards? about kos HOT 4 CLOSED

I just noticed something a minute ago. Previously, @erendrake noticed that some files don't conform to the CRLF end-of-line style, and nobody could see any examples of where that comes from. I just found out where it comes from, I think.

When I changed kRISC.tpg and ran it through TinyPG, it was TinyPG itself that was creating C# files (like Scanner.cs) that are of mixed end-of-line styles. Hopefully this gets corrected upon commit by the git settings, but if you were wondering, that's where it's coming from, I think.

from kos.

I think i goofed and didnt explain myself well on the line endings.

the Auto CRLF setting in git actually just insures that all files are CRLF if you are in windows and when you check in they get changed to LF, I think. its a pretty strange system really but it has made the issue of working on crossplatform projects simpler.

I have thought about adding a .gitattribute file to enforce this setting but frankly i dont know the implications of doing so for people not on windows.

from kos.

Ah that would make sense since git began its life in the UNIX world. It's internals are probably all written to assume LF-only, so it has to convert in and out of that format for Windows users.

from kos.

I think we have a pretty good understanding of our basic style? If we need more work on something lets open a new issue

from kos.