Comments (6)
ktrysmt
commented on August 28, 2024
1
Looks good. DataDavD@421c908
Did you test the behavior of the code? @DataDavD
from go-bitbucket.
ktrysmt
commented on August 28, 2024
1
go test isn't a mandatory procedure but it's important for the project.
But the Branch restriction tests isn't related directly.
Because, I would like to wait to submit the PR by you.
And also, I'll glad whether you fix the BranchRestrictionTests. @DataDavD
from go-bitbucket.
ktrysmt
commented on August 28, 2024
That's sounds good, would you show me the proof of concept?
from go-bitbucket.
DataDavD
commented on August 28, 2024
yea no problem, I kinda prototyped it out in this branch https://github.com/DataDavD/go-bitbucket/tree/add-git-diff-to-resolve-issue-142. I'll provide some better details tonight/tomorrow sometime.
from go-bitbucket.
DataDavD
commented on August 28, 2024
hey @ktrysmt sorry for the delayed response. Been busy since I just changed teams/roles at my company couple weeks ago. I haven't been able to test the code yet, but I will be testing and tweaking it this week. I believe I should be able to submit a PR by the end of this week, but may be the start of next week since we have a holiday weekend this coming weekend. I'll send you the updated branch and test results once I have tested and then we can go from there with how I should submit the PR.
Thank you!!!!!
from go-bitbucket.
ktrysmt
commented on August 28, 2024
done #145
from go-bitbucket.
Related Issues (20)
- Creating a Repo in bitbucket cloud fails with 400 code HOT 2
- Do not os.Exit
- Allow fetching of PipelineConfig
- Use CI to run tests and lint
- How to parse hooks ? HOT 4
- Repositories.ListForTeam tries to deserialize raw stream
- Error running list_test HOT 9
- Question about Client.Auth HOT 5
- Merge Check with approvals
- error: unsupported protocol scheme for Pipelines.List(opt) HOT 5
- Can't specify max depth when listing files
- Unable to get file content
- Ability to trigger new pipelines
- Add support for managing user & group permissions on repositories HOT 1
- fmt.Errorf call has more than one error-wrapping directive %w HOT 1
- Generate Client Using Swagger HOT 5
- Getting lost with how to download a repo
- Authorization using access tokens HOT 1
- GBB
- Add support for Inherited branch protection setting HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-bitbucket.