Comments (2)
@guymguym I've tried several times to re-create this in minikube and have not been able to.
More info:
handleProvision()'s defer handles cleanup for all errors. This is where deleteResources() is called.
Prior to the secret create err, Provision() was called successfully and it returned a partially filled-in ob (so the ob is not nil). We try to create a secret and that fails (for some reason). The CM (nil) and OB (not nil) are skipped and the defer block is invoked. Since the ob is not nil we try to handle it in deleteObjectBucket() and get the Update error in the log.
I'd like to add to the delete<ResourceType>
funcs where they check if the resource is nil, to also check that the name is empty, and only then return. Eg.
if ob == nil || ob.Name == "" {
return nil
}
I still don't know why the secret creation failed but this issue highlights a lib error recovery bug.
from lib-bucket-provisioner.
@guymguym with pr #153 merged can we close this issue?
from lib-bucket-provisioner.
Related Issues (20)
- Change key names in storage class parameters section HOT 2
- Consider using secrets for endpoint info
- Move this repo upstream HOT 2
- Deleted OBCs are waiting in the provisioning queue HOT 8
- attempting to create obc to and external rgw endpoint failing HOT 2
- Do not block OBC request handling on OBC deletion HOT 9
- Additional Config was missing in OBC spec HOT 7
- Adding options to set quota in OBC CRD HOT 2
- Updating of additonal config field of OBC HOT 15
- Update k8s modules to support projects using ks8 v0.18 and up HOT 4
- Library is not thread safe HOT 9
- Remove unnecessary `Get` calls from `deleteExisingSecretAndConfigMapIfExist`
- Fix provision check for empty OB returned HOT 6
- When OBC is deployed using ArgoCD, the reconciliation process does not end HOT 1
- Tagging and Encryption support for provisioned buckets
- should honor empty `SubRegion` HOT 1
- Panic in overwriteAdditionalConfig HOT 4
- Support use the special user to create bucket
- greenfield - Provisioner cannot amend bucket name in OBC after Provision is called
- Archive this repository?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lib-bucket-provisioner.