New OBC create secret already exists fail and fail to cleanup about lib-bucket-provisioner HOT 2 OPEN

@guymguym I've tried several times to re-create this in minikube and have not been able to.

More info:

handleProvision()'s defer handles cleanup for all errors. This is where deleteResources() is called.
Prior to the secret create err, Provision() was called successfully and it returned a partially filled-in ob (so the ob is not nil). We try to create a secret and that fails (for some reason). The CM (nil) and OB (not nil) are skipped and the defer block is invoked. Since the ob is not nil we try to handle it in deleteObjectBucket() and get the Update error in the log.

I'd like to add to the delete<ResourceType> funcs where they check if the resource is nil, to also check that the name is empty, and only then return. Eg.

        if ob == nil || ob.Name == "" {
                return nil
        }

I still don't know why the secret creation failed but this issue highlights a lib error recovery bug.

from lib-bucket-provisioner.

@guymguym with pr #153 merged can we close this issue?

from lib-bucket-provisioner.