Attachment reconciler is incorrectly using nodeid annotation about external-attacher HOT 5 CLOSED

/kind bug
/help
/good-first-issue

from external-attacher.

@msau42:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

from external-attacher.

/assign

from external-attacher.

@msau42, the change you suggested is good to have, still, the annotation is needed to detach volumes from machines that don't have CSINode - for example when they were deleted. I think the logic in getNodeID still works and the annotation was not removed from VolumeAttachment:

from external-attacher.

Thanks, I confused it with the nodeid annotation on Node objects. Maybe adding a comment describing that scenario would be helpful.

from external-attacher.