Giter VIP home page Giter VIP logo

Comments (7)

kenan435 avatar kenan435 commented on May 18, 2024

@aaronlevy Besides prioritizing asset creation order we could prefix asset file names (1-yz.yaml, 2-xyz.yaml etc...) which IMHO is not a good approach. Anyways I made a pq using the former approach. Let me know what you think.

from bootkube.

aaronlevy avatar aaronlevy commented on May 18, 2024

I'm not sure that we need to solve this right away (or potentially in bootkube at all). It is an edge case at the moment, and won't affect bootkube itself right now because kube-dns is the only service we create.

However, a bootkube user was populating the cluster/manifests directory with more addons/services, which meant they were all being created at the same time (and one happened to be randomly assigned the dns service IP).

The asset naming scheme is not a bad idea either - this is a systemd convention for managing drop-in units (e.g. 01-foo.conf, 02-foo.conf).

I think it might be an option to solve this upstream as well where maybe we inform the controller-manager of a range which will be statically assigned.

For example:

--service-cluster-ip-range=10.3.0.0/24
--service-cluster-ip-range-static=10.3.0.0/28

I'll open an upstream issue to discuss the above option.

from bootkube.

dghubble avatar dghubble commented on May 18, 2024

We have another way to add our addons so this probably isn't pressing for us in particular. A simpler solution might be for bootkube to used reserved cluster/system for itself and cluster/manifest for deployer additions. Just to separate manifests bootkube offers guarantees about, from free-form deployer additions.

from bootkube.

fejta-bot avatar fejta-bot commented on May 18, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from bootkube.

fejta-bot avatar fejta-bot commented on May 18, 2024

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

from bootkube.

fejta-bot avatar fejta-bot commented on May 18, 2024

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

from bootkube.

k8s-ci-robot avatar k8s-ci-robot commented on May 18, 2024

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from bootkube.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.