Handle reserved Ips withing an IP range about cluster-api-ipam-provider-in-cluster HOT 8 CLOSED

Currently this is only possible by explicitly specifying which ranges should be used. In this case by writing

addresses:
- 10.10.10.2
- 10.10.10.4-10.10.10.255

That's not a great way of course. We can consider adding a exclude or reserved field to make this easier.

from cluster-api-ipam-provider-in-cluster.

That would be nice and also increase the readability of the configuration. Also makes things easier, if you for instance rather intend to provide a CIDR block instead of ranges.

from cluster-api-ipam-provider-in-cluster.

Hello @schrej I would like to take this up and want to start my contribution journey. Can you please specify the exact location where the change needed? Also it will be helpful if you give me some working solution adn explain the issue in detail
Thank you!

from cluster-api-ipam-provider-in-cluster.

/assign

from cluster-api-ipam-provider-in-cluster.

Hey @Sajiyah-Salat, happy to hear that!
First, you'll need to extend the InClusterIPPoolSpec with a new string list field to list excluded addresses and ranges. I'd call it exclude or something similar.
Then you need to update the PoolSpecToIPSet function in the internal/poolutil package to remove any addresses or ranges listed in the excluded field.
Finally a few tests to verify that the feature works as intended would be great!

I hope that helps you to get started.

from cluster-api-ipam-provider-in-cluster.

@schrej

Wouldn't be helpful to add a name field in exclude?
something similair to this:

exclude:
- name: ci-workers
  address: 10.10.10.5-10.10.10.15
- name: dhcp
  address: 10.10.10.4

from cluster-api-ipam-provider-in-cluster.

Not a big fan of that.
Imo you only need a name or a description if you have a lot of exclusions. And in that case I'd argue that you should size down your pool or specify usable addresses as ranges.

from cluster-api-ipam-provider-in-cluster.

@schrej I've seen that the assignment was removed. I could take over here. Apart from what you have mentioned, I guess the webhook validation also has to be updated, right?

from cluster-api-ipam-provider-in-cluster.