Giter VIP home page Giter VIP logo

Comments (8)

solidnerd avatar solidnerd commented on June 17, 2024 1

@xmudrii I can take it and work from #126 as base. After the merge we can rebase it.

from cluster-api-provider-digitalocean.

nikhita avatar nikhita commented on June 17, 2024

Created #109 to make the error handling consistent across the project.

Re logging: we use glog currently but there has been discussion about how glog might not be a good choice for logging - kubernetes/kubernetes#61006.

Fwiw, with respects to the project moving upstream, Kubernetes itself uses glog right now and it doesn't look like it is going to move away from it soon.

from cluster-api-provider-digitalocean.

solidnerd avatar solidnerd commented on June 17, 2024

Are there any updates regarding the logging topic ?

It seems that a lot of upstream projects use klog right now. This is a kubernetes fork of glog .

from cluster-api-provider-digitalocean.

xmudrii avatar xmudrii commented on June 17, 2024

@solidnerd Moving to klog would be very useful and my plan is to do it once #126 is merged.

If you'd like to take on it as well, let us know. I would just recommend waiting for #126 or working based on that branch, as there are some packages that are added and removed.

from cluster-api-provider-digitalocean.

xmudrii avatar xmudrii commented on June 17, 2024

@solidnerd Sounds good, thanks! :)

from cluster-api-provider-digitalocean.

solidnerd avatar solidnerd commented on June 17, 2024

@xmudrii what is missing here to bring this issue over the line ?

from cluster-api-provider-digitalocean.

xmudrii avatar xmudrii commented on June 17, 2024

@solidnerd I think it's okay to close this issue. Thanks for the help!

/close

from cluster-api-provider-digitalocean.

k8s-ci-robot avatar k8s-ci-robot commented on June 17, 2024

@xmudrii: Closing this issue.

In response to this:

@solidnerd I think it's okay to close this issue. Thanks for the help!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from cluster-api-provider-digitalocean.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.