Comments (8)
@xmudrii I can take it and work from #126 as base. After the merge we can rebase it.
from cluster-api-provider-digitalocean.
Created #109 to make the error handling consistent across the project.
Re logging: we use glog currently but there has been discussion about how glog might not be a good choice for logging - kubernetes/kubernetes#61006.
Fwiw, with respects to the project moving upstream, Kubernetes itself uses glog right now and it doesn't look like it is going to move away from it soon.
from cluster-api-provider-digitalocean.
Are there any updates regarding the logging topic ?
It seems that a lot of upstream projects use klog
right now. This is a kubernetes fork of glog .
from cluster-api-provider-digitalocean.
@solidnerd Moving to klog
would be very useful and my plan is to do it once #126 is merged.
If you'd like to take on it as well, let us know. I would just recommend waiting for #126 or working based on that branch, as there are some packages that are added and removed.
from cluster-api-provider-digitalocean.
@solidnerd Sounds good, thanks! :)
from cluster-api-provider-digitalocean.
@xmudrii what is missing here to bring this issue over the line ?
from cluster-api-provider-digitalocean.
@solidnerd I think it's okay to close this issue. Thanks for the help!
/close
from cluster-api-provider-digitalocean.
@xmudrii: Closing this issue.
In response to this:
@solidnerd I think it's okay to close this issue. Thanks for the help!
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from cluster-api-provider-digitalocean.
Related Issues (20)
- Separate ci jobs between master branch and release-0.4 branch
- Upgrade dependencies based on minimum version for capi v1alpha4 HOT 2
- Generated code may go to `$GOPATH/src` instead of in repo
- Support CAPI paused annotation HOT 3
- Fix golang-ci lint configuration exclude configuration HOT 3
- Branch rename master -> main HOT 1
- Does not work with latest clusterctl HOT 7
- Update README.md to reflect v1beta1 status HOT 17
- Create a SECURITY_CONTACTS file. HOT 3
- Create a SECURITY_CONTACTS file. HOT 2
- Store LB uuid in DOCluster spec HOT 1
- Consider if to align manager flag names with upstream Kubernetes components HOT 1
- Allow updates to controlPlaneEndpoint HOT 2
- Correction of generating a workload cluster command from config to generate HOT 1
- Error when building ubuntu-2004 image HOT 5
- Cluster migration causes LB issues HOT 9
- Error: failed to get provider components for the "digitalocean" provider HOT 4
- CAPI v1.5.0-beta.0 has been released and is ready for testing HOT 2
- CAPI v1.6.0-beta.0 has been released and is ready for testing HOT 4
- CAPI v1.7.0-beta.0 has been released and is ready for testing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cluster-api-provider-digitalocean.