Comments (15)
@gyliu513 I'm trying to understand how to set credential to access quay.io
in travis. After that, I will fix this issue.
from cluster-api-provider-ibmcloud.
@gyliu513 as we already under account cluster-api-provider-ibmcloud
, shall we use names controller
and clusterctl
for simple. Especially for clusterctl
, I think it is better descriptive in docker run quay.io/cluster-api-provider-ibmcloud/clusterctl ...
from cluster-api-provider-ibmcloud.
@xunpan +1 to use simple name, you can create PR to fix this.
from cluster-api-provider-ibmcloud.
+1 to the simple naming given the namespace we added
from cluster-api-provider-ibmcloud.
@xunpan can you help check how federation v2 push the latest image to quay.io
? We can follow same way for ibmcloud.
/assign @xunpan
from cluster-api-provider-ibmcloud.
federation push image to quay.io
when CI succeed. It pushes images for kubernetes-multicluster/federation-v2
with canary
, latest
and tag version, e.g. v0.0.9
.
from cluster-api-provider-ibmcloud.
@xunpan Yes, shall we follow same logic for ibmcloud images?
from cluster-api-provider-ibmcloud.
how to set credential to access quay.io
Yes, this is exactly what we should do.
from cluster-api-provider-ibmcloud.
@xunpan I think we need to put the credential in k8s secret that prow jobs can access.
from cluster-api-provider-ibmcloud.
only want to make sure my understanding, we will push the image when
CI passed and merged into master or just CI passed and push to registry for test purpose?
both works for me but I want to make sure I understand the correct way, thank you @morvencao @gyliu513 @xunpan
from cluster-api-provider-ibmcloud.
The logic is pushing image after CI passed for canary
image. The code at the moment is not merged yet. CI is prerequisite for merge but not do code merge automatically.
For release versioned and latest (latest release one), they are only push by a tag (for release).
from cluster-api-provider-ibmcloud.
@morvencao I guess it is not for this case to pass credential manually by k8s secret. It is better to set it in security place and follow up existing practise.
from cluster-api-provider-ibmcloud.
federation v2
uses travis ci but ibmcloud cluster api uses test-infra
.
from cluster-api-provider-ibmcloud.
I think it has no existing ways to push image automatically to cloud and keep security private in test-infra.
- there is no response from sig-testing community in slack
- checked related provider and their settings in test-infra
I'm still thinking is it necessary to make automatically pushed.
- For end users, they can use released image. We upload it in each release by the script. The lates version seems makes less sense to them.
- For develpers, they can build their own version by the scripts.
Any comments? @gyliu513
from cluster-api-provider-ibmcloud.
@xunpan +1 for this, let me close this issue.
from cluster-api-provider-ibmcloud.
Related Issues (20)
- Include make verify-security to release-0.5 and release-0.6 branches HOT 3
- Update template references with commands in docs to point to correct templates HOT 2
- Handle VPC LB logic without modification of Spec.ControlPlaneEndpoint.Host field HOT 3
- Build and Publish latest k8s 1.28.x images for VPC and PowerVS HOT 3
- Enhance linting to cover yaml files HOT 9
- Add support and release content to CAPIBM book doc HOT 5
- Add instructions in doc to update release versions in security-scan workflow HOT 7
- Template: Update cluster-api to v1.x.x HOT 4
- Merge podman titl doc into the tilt development doc HOT 5
- Optimise golang version update across multiple files HOT 1
- Fix index pages content in book HOT 8
- Docs: identifying scope of improvement HOT 2
- E2e tests are failing HOT 2
- Replace pvsadm image import reference with capibmadm powervs image import HOT 5
- Handle create workflow of newly proposed Power VS cluster creation method HOT 4
- Handle delete workflow of newly proposed Power VS cluster creation method HOT 4
- Enhance packer plugin for the powervs dhcp network
- git describe from the Make files state `fatal: No names found, cannot describe anything.`
- VPC e2e is failing in eu-de region HOT 4
- EPIC - Introduce new API Specs and infra creation flow HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cluster-api-provider-ibmcloud.