Giter VIP home page Giter VIP logo

Comments (15)

xunpan avatar xunpan commented on June 22, 2024 1

@gyliu513 I'm trying to understand how to set credential to access quay.io in travis. After that, I will fix this issue.

from cluster-api-provider-ibmcloud.

xunpan avatar xunpan commented on June 22, 2024

@gyliu513 as we already under account cluster-api-provider-ibmcloud, shall we use names controller and clusterctl for simple. Especially for clusterctl, I think it is better descriptive in docker run quay.io/cluster-api-provider-ibmcloud/clusterctl ...

from cluster-api-provider-ibmcloud.

gyliu513 avatar gyliu513 commented on June 22, 2024

@xunpan +1 to use simple name, you can create PR to fix this.

from cluster-api-provider-ibmcloud.

jichenjc avatar jichenjc commented on June 22, 2024

+1 to the simple naming given the namespace we added

from cluster-api-provider-ibmcloud.

gyliu513 avatar gyliu513 commented on June 22, 2024

@xunpan can you help check how federation v2 push the latest image to quay.io? We can follow same way for ibmcloud.

/assign @xunpan

from cluster-api-provider-ibmcloud.

xunpan avatar xunpan commented on June 22, 2024

federation push image to quay.io when CI succeed. It pushes images for kubernetes-multicluster/federation-v2 with canary, latest and tag version, e.g. v0.0.9.

from cluster-api-provider-ibmcloud.

gyliu513 avatar gyliu513 commented on June 22, 2024

@xunpan Yes, shall we follow same logic for ibmcloud images?

from cluster-api-provider-ibmcloud.

gyliu513 avatar gyliu513 commented on June 22, 2024

how to set credential to access quay.io

Yes, this is exactly what we should do.

from cluster-api-provider-ibmcloud.

morvencao avatar morvencao commented on June 22, 2024

@xunpan I think we need to put the credential in k8s secret that prow jobs can access.

from cluster-api-provider-ibmcloud.

jichenjc avatar jichenjc commented on June 22, 2024

only want to make sure my understanding, we will push the image when
CI passed and merged into master or just CI passed and push to registry for test purpose?
both works for me but I want to make sure I understand the correct way, thank you @morvencao @gyliu513 @xunpan

from cluster-api-provider-ibmcloud.

xunpan avatar xunpan commented on June 22, 2024

The logic is pushing image after CI passed for canary image. The code at the moment is not merged yet. CI is prerequisite for merge but not do code merge automatically.

For release versioned and latest (latest release one), they are only push by a tag (for release).

from cluster-api-provider-ibmcloud.

xunpan avatar xunpan commented on June 22, 2024

@morvencao I guess it is not for this case to pass credential manually by k8s secret. It is better to set it in security place and follow up existing practise.

from cluster-api-provider-ibmcloud.

xunpan avatar xunpan commented on June 22, 2024

federation v2 uses travis ci but ibmcloud cluster api uses test-infra.

from cluster-api-provider-ibmcloud.

xunpan avatar xunpan commented on June 22, 2024

I think it has no existing ways to push image automatically to cloud and keep security private in test-infra.
- there is no response from sig-testing community in slack
- checked related provider and their settings in test-infra

I'm still thinking is it necessary to make automatically pushed.

  • For end users, they can use released image. We upload it in each release by the script. The lates version seems makes less sense to them.
  • For develpers, they can build their own version by the scripts.

Any comments? @gyliu513

from cluster-api-provider-ibmcloud.

gyliu513 avatar gyliu513 commented on June 22, 2024

@xunpan +1 for this, let me close this issue.

from cluster-api-provider-ibmcloud.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.