Giter VIP home page Giter VIP logo

Comments (12)

deitch avatar deitch commented on September 23, 2024

However, you can see that the type is not unique enough to distinguish. Each respective type, e.g IPv4, IPv6, and private vs. public should have unique types to reference.

Correct. This is part of the core CAPI spec, see type MachineAddressType which only is one of:

  • Hostname
  • InternalIP
  • ExternalIP
  • InternalDNS
  • ExternalDNS

We don't have any real control over this to make it more precise. You can raise an issue on cluster-api if you want more precise details, or even just tags that can be applied, but it will have to be hooked into the right places in the Reconcile() loop.

from cluster-api-provider-packet.

deitch avatar deitch commented on September 23, 2024

Also, it appears as though the creation of the master and the IP it's able to advertise is coupled with the ability to create + apply an elastic IP

It is. You can do a single node control plane (CAPP used to have that), but if you want a multi-master control plane, you need to create the IP before creating the first node. This is part and parcel of how CAPI works. Even doing the single-node assumes that, but we sort of "cheated" by saying it was ready when it wasn't.

if you can omit the `{{ .controlPlaneEndpoint }} and have it default to one of the hosts' addresses, then maybe just the docs need to be updated, otherwise it would be valuable to be able to reference these as variables during the cluster initialization.

How would that work? The way CAPBK works, it uses the controlPlaneEndpoint to create the kubeconfig (/etc/kubernetes/admin.yaml, but the others as well), and then tries to reach it in kubeadm init phase wait-control-plane; it then reuses that same address in kubeadm join.

The end goal being that one does not have to have an elastic IP assigned to the master, and could reference a variable like InternalIP within the respective kubeadmConfigSpec blocks; ex

I see what you are trying to do. I tried to get it somewhere similar, but didn't have any success. It uses controlPlaneEndpoint to generate the kubeconfig, so it will get stuck on wait-control-plane no matter what you do.

You don't actually need CAPP or CAPI for this. The contents of initConfiguration and joinConfiguration are identical to those in a regular kubeadm yaml. Just spin up a node, install kubeadm, create the kubeadm.yaml you want, and run an experiment. If you can get it to work, more than happy to roll it here into CAPP.

from cluster-api-provider-packet.

matoszz avatar matoszz commented on September 23, 2024

@deitch while the initConfiguration and joinConfiguration are identical, I can't use the variables from the machine in that specification as far as I know, unless you're saying I should be able to pass in a variable like InternalIP?

from cluster-api-provider-packet.

deitch avatar deitch commented on September 23, 2024

I can't use the variables from the machine in that specification as far as I know

No, you cannot. I know of no way that kubeadm will inject runtime information into its parsed config. You can inject it at the CAPI level, using templates (as we do with controlPlaneEndpoint), but kubeadm itself isn't doing it.

from cluster-api-provider-packet.

fejta-bot avatar fejta-bot commented on September 23, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from cluster-api-provider-packet.

fejta-bot avatar fejta-bot commented on September 23, 2024

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

from cluster-api-provider-packet.

fejta-bot avatar fejta-bot commented on September 23, 2024

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

from cluster-api-provider-packet.

k8s-ci-robot avatar k8s-ci-robot commented on September 23, 2024

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from cluster-api-provider-packet.

cprivitere avatar cprivitere commented on September 23, 2024

/remove-lifecycle rotten

from cluster-api-provider-packet.

cprivitere avatar cprivitere commented on September 23, 2024

/reopen

from cluster-api-provider-packet.

k8s-ci-robot avatar k8s-ci-robot commented on September 23, 2024

@cprivitere: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from cluster-api-provider-packet.

cprivitere avatar cprivitere commented on September 23, 2024

I'm closing this with a better comment. We can't do this as asked due to limitations in Cluster API. But even if we could, the actual effect in kubeadm would not be what people actually want (people want a floating external IP and internal only IPs that the clusters use to talk to each other...kubeadm just can't do it with its current options/flags). We do need some sort of internal only IP solution for CAPP, however, that we'll tackle in a separate issue. And hopefully I'll remember to come back and update this if kubeadm options expand in the future to permit this better.

from cluster-api-provider-packet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.